-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexing: add Doc status counter #8716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1walz
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
July 17, 2023 08:19
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/internalClusterTest/java/org/opensearch/nodestats/NodeStatsIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/nodestats/NodeStatsIT.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
r1walz
force-pushed
the
ra/idx-axn-cntr
branch
from
September 28, 2023 11:19
42f9d21
to
2e33919
Compare
r1walz
commented
Sep 28, 2023
server/src/internalClusterTest/java/org/opensearch/nodestats/NodeStatsIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/nodestats/NodeStatsIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/nodestats/NodeStatsIT.java
Outdated
Show resolved
Hide resolved
Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. Tracking these failures requires client to parse the response on their side and make sense of them. But, a general idea around trend in growth of different rest status codes at item level can provide insights on how indexing engine is performing. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
r1walz
force-pushed
the
ra/idx-axn-cntr
branch
from
September 28, 2023 11:33
2e33919
to
0663f12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @r1walz . LGTM
shwetathareja
approved these changes
Sep 28, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Indexing: add Doc Status Counter (#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
r1walz
added a commit
to r1walz/OpenSearch
that referenced
this pull request
Sep 29, 2023
[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267) * Indexing: add Doc Status Counter (opensearch-project#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
sgup432
added a commit
to sgup432/OpenSearch
that referenced
this pull request
Sep 29, 2023
[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267) * Indexing: add Doc Status Counter (opensearch-project#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
sgup432
added a commit
to sgup432/OpenSearch
that referenced
this pull request
Sep 29, 2023
[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267) * Indexing: add Doc Status Counter (opensearch-project#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
msfroh
pushed a commit
that referenced
this pull request
Sep 30, 2023
* [Search latency - Coordinator] Changing version check to 2.11 Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * [Port main] update version check as per v2.11.0 [Backport 2.x] Indexing: add Doc status counter (#10267) * Indexing: add Doc Status Counter (#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey
pushed a commit
to rayshrey/OpenSearch
that referenced
this pull request
Oct 3, 2023
…arch-project#10280) * [Search latency - Coordinator] Changing version check to 2.11 Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * [Port main] update version check as per v2.11.0 [Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267) * Indexing: add Doc Status Counter (opensearch-project#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
to deshsidd/OpenSearch
that referenced
this pull request
Oct 9, 2023
Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
deshsidd
pushed a commit
to deshsidd/OpenSearch
that referenced
this pull request
Oct 9, 2023
…arch-project#10280) * [Search latency - Coordinator] Changing version check to 2.11 Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * [Port main] update version check as per v2.11.0 [Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267) * Indexing: add Doc Status Counter (opensearch-project#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90
pushed a commit
to vikasvb90/OpenSearch
that referenced
this pull request
Oct 10, 2023
Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
vikasvb90
pushed a commit
to vikasvb90/OpenSearch
that referenced
this pull request
Oct 10, 2023
…arch-project#10280) * [Search latency - Coordinator] Changing version check to 2.11 Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * [Port main] update version check as per v2.11.0 [Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267) * Indexing: add Doc Status Counter (opensearch-project#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mgodwan
pushed a commit
to mgodwan/OpenSearch
that referenced
this pull request
Oct 17, 2023
Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…arch-project#10280) * [Search latency - Coordinator] Changing version check to 2.11 Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * [Port main] update version check as per v2.11.0 [Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267) * Indexing: add Doc Status Counter (opensearch-project#8716) Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc. Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> (cherry picked from commit d656e3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 94173e3) Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
Clients
Clients within the Core repository such as High level Rest client and low level client
distributed framework
enhancement
Enhancement or improvement to existing feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Opensearch returns a 200 OK response code for a Bulk API call, even though there can be partial/complete failures within the request E2E. Tracking these failures requires client to parse the response on their side and make sense of them. But, a general idea around trend in growth of different rest status codes at item level can provide insights on how indexing engine is performing.
Related Issues
Resolves #4562
Check List
Benchmarks!
DocStatusCounter Benchmarking
Configuration:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.