Fix local segments stats update in RemoteStoreRefreshListener #8758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8758 +/- ##
============================================
- Coverage 71.06% 71.02% -0.04%
- Complexity 57314 57331 +17
============================================
Files 4766 4765 -1
Lines 270453 270478 +25
Branches 39555 39552 -3
============================================
- Hits 192197 192115 -82
- Misses 62045 62199 +154
+ Partials 16211 16164 -47
|
Gradle Check (Jenkins) Run Completed with:
|
ashking94
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89 and
tlfeng
as code owners
|
Rebased with main and committed as single commit as it was getting difficult to rebase every time. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
approved these changes
Aug 5, 2023
server/src/main/java/org/opensearch/index/shard/CloseableRetryableRefreshListener.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/CloseableRetryableRefreshListener.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/CloseableRetryableRefreshListener.java
Show resolved
Hide resolved
Signed-off-by: Ashish Singh <ssashish@amazon.com>
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 6, 2023
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 2416d45) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Aug 11, 2023
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Aug 12, 2023
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Aug 12, 2023
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Aug 12, 2023
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Aug 13, 2023
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com>
sachinpkale
pushed a commit
that referenced
this pull request
Aug 14, 2023
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…arch-project#8758) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, if a refresh occurs for an IndexShard, the afterRefresh method of
ReferenceManager.RefreshListener(Lucene class) objects are invoked. RemoteStoreRefreshListener, currently, has the responsibility of updating the segment tracker with the upto date information of segment files which are part of the most recent refresh. It also has the responsibility of uploading the segments to the remote store after each refresh and then updating the segment tracker with the relevant information about the upload. This information is exposed via remote store stats api and is also used for rejection incoming write requests when there is a lag between the local store and the remote store (remote segment backpressure). While updating the tracker with local state happens at the beginning of theperformAfterRefresh, there can be cases where the retry could have been blocking the performAfterRefresh (& hence the local state update in segment tracker). This would lead to incorrect information being saved in tracker due to the tight coupling.With this PR, we aim to introduce a new method inside the
CloseableRetryableRefreshListenerwhich gets executed exactly once. The idempotent logic can continue to reside in theperformAfterRefreshWithPermitmethod. We are also adding tests for existing classes that covers more flows.Related Issues
Resolves #8717
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.