Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Change remote store integ tests to use remote store for replication #8768

Merged

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Jul 19, 2023

Description

  • Currently, we have remote store integ tests where replication is node-to-node.
  • As we have introduced support of using remote store for replication, we will no longer support node-to-node replication when remote store is enabled.
  • This change makes sure to use remote store for replication for all the integ tests related to remote store and removes redundant tests.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #8768 (32cc3c5) into main (57d5e90) will increase coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8768      +/-   ##
============================================
+ Coverage     70.76%   70.93%   +0.17%     
- Complexity    57111    57196      +85     
============================================
  Files          4771     4771              
  Lines        270241   270241              
  Branches      39500    39500              
============================================
+ Hits         191237   191702     +465     
+ Misses        62846    62416     -430     
+ Partials      16158    16123      -35     

see 488 files with indirect coverage changes

@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jul 19, 2023
@sachinpkale sachinpkale merged commit 1d3b006 into opensearch-project:main Jul 19, 2023
12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2023
…r replication (#8768)

* Change remote store integ tests to use remote store for replication

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 1d3b006)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have multiple Integ tests like CreateRemoteIndexIT, CreateRemoteIndexTranslogDisabledIT which are also written for remote store features. We might want to have the changes done here as well.

@sachinpkale
Copy link
Member Author

sachinpkale commented Jul 19, 2023

We have multiple Integ tests like CreateRemoteIndexIT, CreateRemoteIndexTranslogDisabledIT which are also written for remote store features. We might want to have the changes done here as well.

The other integ tests do not use replication (for example CreateRemoteIndexIT just checks if index with remote settings can be created as per the expectation). Enabling segrep experimental feature flag would have no impact on these tests.

kotwanikunal pushed a commit that referenced this pull request Jul 19, 2023
…r replication (#8768) (#8774)

* Change remote store integ tests to use remote store for replication

---------



(cherry picked from commit 1d3b006)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…r replication (opensearch-project#8768)

* Change remote store integ tests to use remote store for replication

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…r replication (opensearch-project#8768)

* Change remote store integ tests to use remote store for replication

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…r replication (opensearch-project#8768)

* Change remote store integ tests to use remote store for replication

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants