Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Refactor] StreamIO from common to core.common namespace in core lib (#8157) #8782

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 19, 2023

Backport e354201 from #8157.

…pensearch-project#8157)

* [Refactor] StreamIO from common to core.common in core lib

This PR is a mechanical refactor of all Stream classes in
o.o.common.io.stream to o.o.core.common.io.stream namespace.
In addition to the namespace refactor several loose end classes in
o.o.common.io.stream of the :server module are refactored to
o.o.core.common.io.stream of the :libs:opensearch-core library. These
classes include the following:

* ByteBufferStreamInpu
* BytesStreamInput
* DataOutputStreamOutput
* FilterStreamInput
* NamedWriteableAwareStreamInput
* OutputStreamStreamOutput
* VersionedNamedWriteable

Companion tests are also refactored from the server test folder to the
corresponding core test folder.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments v2.10.0 labels Jul 19, 2023
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollCreatedOnReplica

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testReplicaHasDiffFilesThanPrimary
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testPitCreatedOnReplica

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #8782 (6bdbb86) into 2.x (59197bb) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #8782      +/-   ##
============================================
- Coverage     70.72%   70.69%   -0.04%     
- Complexity    57329    57387      +58     
============================================
  Files          4759     4759              
  Lines        271587   271577      -10     
  Branches      40035    40034       -1     
============================================
- Hits         192080   191990      -90     
- Misses        63026    63109      +83     
+ Partials      16481    16478       -3     
Impacted Files Coverage Δ
...mark/search/aggregations/TermsReduceBenchmark.java 0.00% <ø> (ø)
...ucket/terms/StringTermsSerializationBenchmark.java 0.00% <ø> (ø)
...ch/plugin/noop/action/bulk/RestNoopBulkAction.java 0.00% <ø> (ø)
...ugin/noop/action/bulk/TransportNoopBulkAction.java 0.00% <ø> (ø)
.../noop/action/search/TransportNoopSearchAction.java 0.00% <ø> (ø)
...main/java/org/opensearch/client/ClusterClient.java 8.57% <ø> (ø)
...java/org/opensearch/client/GetAliasesResponse.java 88.75% <ø> (ø)
...main/java/org/opensearch/client/IndicesClient.java 1.77% <ø> (ø)
.../java/org/opensearch/client/RequestConverters.java 84.52% <ø> (+0.49%) ⬆️
...ava/org/opensearch/client/RestHighLevelClient.java 41.94% <ø> (ø)
... and 140 more

... and 483 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants