Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Refactor] StreamIO from common to core.common namespace in core lib (#8157) #8782

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[Backport 2.x] [Refactor] StreamIO from common to core.common namespace in core lib (#8157) #8782

merged 2 commits into from
Jul 19, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 19, 2023

Backport e354201 from #8157.

@nknize
[Refactor] StreamIO from common to core.common namespace in core lib (o…
bf74d32 
…pensearch-project#8157)

* [Refactor] StreamIO from common to core.common in core lib

This PR is a mechanical refactor of all Stream classes in
o.o.common.io.stream to o.o.core.common.io.stream namespace.
In addition to the namespace refactor several loose end classes in
o.o.common.io.stream of the :server module are refactored to
o.o.core.common.io.stream of the :libs:opensearch-core library. These
classes include the following:

* ByteBufferStreamInpu
* BytesStreamInput
* DataOutputStreamOutput
* FilterStreamInput
* NamedWriteableAwareStreamInput
* OutputStreamStreamOutput
* VersionedNamedWriteable

Companion tests are also refactored from the server test folder to the
corresponding core test folder.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments v2.10.0 labels Jul 19, 2023
@nknize
update changelog
6bdbb86 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollCreatedOnReplica

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testReplicaHasDiffFilesThanPrimary
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testPitCreatedOnReplica

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #8782 (6bdbb86) into 2.x (59197bb) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #8782      +/-   ##
============================================
- Coverage     70.72%   70.69%   -0.04%     
- Complexity    57329    57387      +58     
============================================
  Files          4759     4759              
  Lines        271587   271577      -10     
  Branches      40035    40034       -1     
============================================
- Hits         192080   191990      -90     
- Misses        63026    63109      +83     
+ Partials      16481    16478       -3
Impacted Files Coverage Δ
...mark/search/aggregations/TermsReduceBenchmark.java 0.00% <ø> (ø)
...ucket/terms/StringTermsSerializationBenchmark.java 0.00% <ø> (ø)
...ch/plugin/noop/action/bulk/RestNoopBulkAction.java 0.00% <ø> (ø)
...ugin/noop/action/bulk/TransportNoopBulkAction.java 0.00% <ø> (ø)
.../noop/action/search/TransportNoopSearchAction.java 0.00% <ø> (ø)
...main/java/org/opensearch/client/ClusterClient.java 8.57% <ø> (ø)
...java/org/opensearch/client/GetAliasesResponse.java 88.75% <ø> (ø)
...main/java/org/opensearch/client/IndicesClient.java 1.77% <ø> (ø)
.../java/org/opensearch/client/RequestConverters.java 84.52% <ø> (+0.49%) ⬆️
...ava/org/opensearch/client/RestHighLevelClient.java 41.94% <ø> (ø)
... and 140 more

... and 483 files with indirect coverage changes

@andrross andrross merged commit 0ea7210 into opensearch-project:2.x Jul 19, 2023
8 checks passed
@DarshitChanpura DarshitChanpura mentioned this pull request Jul 19, 2023
Merged
3 tasks
@MaxKsyunz MaxKsyunz mentioned this pull request Jul 20, 2023
Merged
2 tasks
@Hailong-am Hailong-am mentioned this pull request Jul 21, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nknize @andrross