Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test - org.opensearch.repositories.blobstore.BlobStoreRepos… #8835

Merged

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Jul 24, 2023

…itoryTests

Description

  • Recently we mandated the remote indices be created with remote translog and segment store both.
  • Before this change the BlobStoreRepositoryTests were creating remote indices with just segment store and not translog.
  • With Translog enabled remote indices in BlobStoreRepositoryTests, with certain seed the repo had an empty extra0 file in translog metadata dir which was causing the CorruptIndexException while reading metadata file for translog
  • With this change we ensure no extra0 file is created in translog metadata dir

Related Issues

Resolves #8834

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…itoryTests

Signed-off-by: bansvaru <bansvaru@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #8835 (ac5540c) into main (c47ec1b) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8835      +/-   ##
============================================
+ Coverage     70.96%   71.04%   +0.07%     
- Complexity    57191    57259      +68     
============================================
  Files          4771     4771              
  Lines        270235   270235              
  Branches      39497    39497              
============================================
+ Hits         191780   191996     +216     
+ Misses        62255    62091     -164     
+ Partials      16200    16148      -52     

see 441 files with indirect coverage changes

@sachinpkale sachinpkale merged commit a29521e into opensearch-project:main Jul 24, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jul 24, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
…itoryTests (#8835)

Signed-off-by: bansvaru <bansvaru@amazon.com>
(cherry picked from commit a29521e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@linuxpi linuxpi deleted the fix-blobstore-repo-flaky branch July 24, 2023 09:38
sachinpkale pushed a commit that referenced this pull request Jul 24, 2023
…itoryTests (#8835) (#8837)

(cherry picked from commit a29521e)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…itoryTests (opensearch-project#8835)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…itoryTests (opensearch-project#8835)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…itoryTests (opensearch-project#8835)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Multiple UTs in org.opensearch.repositories.blobstore.BlobStoreRepositoryTests are flaky
2 participants