Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version guards to deal for aggregation profiler with concurren… #9017

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ticheng-aws
Copy link
Contributor

Description

#9015

Related Issues

Resolves #8331

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…t aggregation

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/330_auto_date_histogram/profile at top level}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/20_terms/string profiler via global ordinals}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/20_terms/string profiler via global ordinals}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/profiler unsigned_long}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/profiler unsigned_long}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/profiler unsigned_long}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/profiler string}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/profiler double}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/profiler double}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/10_histogram/date_histogram profiler}

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #9017 (5195f07) into main (b2a7348) will increase coverage by 0.51%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #9017      +/-   ##
============================================
+ Coverage     71.04%   71.56%   +0.51%     
- Complexity    57246    57616     +370     
============================================
  Files          4764     4764              
  Lines        270153   270153              
  Branches      39532    39532              
============================================
+ Hits         191937   193328    +1391     
+ Misses        62027    60852    -1175     
+ Partials      16189    15973     -216     
Files Changed Coverage Δ
...a/org/opensearch/search/profile/ProfileResult.java 94.69% <0.00%> (ø)

... and 445 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@reta reta merged commit f2ca769 into opensearch-project:main Aug 1, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…t aggregation (opensearch-project#9017)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…t aggregation (opensearch-project#9017)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…t aggregation (opensearch-project#9017)

Signed-off-by: Ticheng Lin <ticheng@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concurrent Segment Search] Add support for aggregation profiler with concurrent aggregation
2 participants