-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Unmute testIndexingWithSegRep rolling upgrade test #9079
Conversation
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9079 +/- ##
============================================
+ Coverage 70.97% 71.74% +0.76%
- Complexity 57195 57778 +583
============================================
Files 4765 4765
Lines 270334 270334
Branches 39538 39538
============================================
+ Hits 191879 193951 +2072
+ Misses 62282 60522 -1760
+ Partials 16173 15861 -312 |
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
org.opensearch.transport.nio.SimpleMockNioTransportTests.testTracerLog |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
org.opensearch.snapshots.DeleteSnapshotIT.testDeleteMultipleShallowCopySnapshotsCase1
|
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9079-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f73aac93b78691dbf197d3fd35f7406fa8717e9c
# Push it to GitHub
git push --set-upstream origin backport/backport-9079-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…est (opensearch-project#9079) * Unmute testIndexingWithSegRep rolling upgrade test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Assert on row count before processing the result Signed-off-by: Suraj Singh <surajrider@gmail.com> * Filter rows with 0 doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> * Retry assertHitCount Signed-off-by: Suraj Singh <surajrider@gmail.com> * Handle exception Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add comment Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
…est (opensearch-project#9079) * Unmute testIndexingWithSegRep rolling upgrade test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Assert on row count before processing the result Signed-off-by: Suraj Singh <surajrider@gmail.com> * Filter rows with 0 doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> * Retry assertHitCount Signed-off-by: Suraj Singh <surajrider@gmail.com> * Handle exception Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add comment Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
…est (opensearch-project#9079) * Unmute testIndexingWithSegRep rolling upgrade test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Assert on row count before processing the result Signed-off-by: Suraj Singh <surajrider@gmail.com> * Filter rows with 0 doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> * Retry assertHitCount Signed-off-by: Suraj Singh <surajrider@gmail.com> * Handle exception Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add comment Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
…est (opensearch-project#9079) * Unmute testIndexingWithSegRep rolling upgrade test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Assert on row count before processing the result Signed-off-by: Suraj Singh <surajrider@gmail.com> * Filter rows with 0 doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> * Retry assertHitCount Signed-off-by: Suraj Singh <surajrider@gmail.com> * Handle exception Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add comment Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…est (opensearch-project#9079) * Unmute testIndexingWithSegRep rolling upgrade test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Assert on row count before processing the result Signed-off-by: Suraj Singh <surajrider@gmail.com> * Filter rows with 0 doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> * Retry assertHitCount Signed-off-by: Suraj Singh <surajrider@gmail.com> * Handle exception Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add comment Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…est (opensearch-project#9079) * Unmute testIndexingWithSegRep rolling upgrade test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Assert on row count before processing the result Signed-off-by: Suraj Singh <surajrider@gmail.com> * Filter rows with 0 doc count Signed-off-by: Suraj Singh <surajrider@gmail.com> * Retry assertHitCount Signed-off-by: Suraj Singh <surajrider@gmail.com> * Handle exception Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add comment Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
testIndexingWithSegRep
as [Segment Replication] Add logic back to update tracking replication checkpoint on source #8560 (pre-requisite for segment replication bwc test) is merged to main and backported to 2.x.IndexOutOfBoundsException
as mentioned here. [Edit]: Needed to remove rows with0
doc count before adding assertion of number of rows to be multiple of shard copies.Related Issues
Resolves: #7679
Test
Ran test in a loop for
500100 iterations without failure on mainand 2.xmain
Will test for 2.x separately in backport PR.
2.xfor in in {1..100}; do ./gradlew ':qa:rolling-upgrade:v2.8.1#upgradedClusterTest' --tests "org.opensearch.upgrades.IndexingIT.testIndexingWithSegRep" -Dtests.seed=395148148DFDD176 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-BA -Dtests.timezone=America/North_Dakota/Beulah -Druntime.java=17 >> /tmp/bwc_test; done
...
(base) ubuntu@ip-172-31-49-145:~/OpenSearch$ grep "BUILD SUCCESSFUL" /tmp/bwc_test | wc -l
100
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.