-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Referencing default and best compressions codecs as their algo name #9123
Referencing default and best compressions codecs as their algo name #9123
Conversation
643f060
to
4e1a383
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
4e1a383
to
bb6169b
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9123 +/- ##
============================================
- Coverage 71.06% 70.98% -0.08%
+ Complexity 57314 57284 -30
============================================
Files 4766 4765 -1
Lines 270453 270482 +29
Branches 39555 39552 -3
============================================
- Hits 192197 192010 -187
- Misses 62045 62272 +227
+ Partials 16211 16200 -11
|
bb6169b
to
b449430
Compare
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
b449430
to
0ed56e7
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
0ed56e7
to
393dbf1
Compare
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:
|
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9123-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3713bcb1ab69d18cc990cd36f91f5b5261b71132
# Push it to GitHub
git push --set-upstream origin backport/backport-9123-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@sarthakaggarwal97 could you please send manual backport to |
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
The users will be able to set the codecs in the index settings using their algorithm names. This will help the user get visibility on the algorithm being used in the background for compression
Related Issues
Resolves #8695
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.