Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing default and best compressions codecs as their algo name #9123

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Aug 4, 2023

Description

The users will be able to set the codecs in the index settings using their algorithm names. This will help the user get visibility on the algorithm being used in the background for compression

Related Issues

Resolves #8695

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97 sarthakaggarwal97 changed the title introducing codecs as their algo name Referencing default and best compressions codecs as their algo name Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #9123 (393dbf1) into main (bb78930) will decrease coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 75.95%.

@@             Coverage Diff              @@
##               main    #9123      +/-   ##
============================================
- Coverage     71.06%   70.98%   -0.08%     
+ Complexity    57314    57284      -30     
============================================
  Files          4766     4765       -1     
  Lines        270453   270482      +29     
  Branches      39555    39552       -3     
============================================
- Hits         192197   192010     -187     
- Misses        62045    62272     +227     
+ Partials      16211    16200      -11     
Files Changed Coverage Δ
.../opensearch/client/indices/CreateIndexRequest.java 76.66% <0.00%> (ø)
...opensearch/client/slm/SnapshotLifecyclePolicy.java 0.00% <ø> (ø)
...ch/client/slm/SnapshotLifecyclePolicyMetadata.java 0.00% <ø> (ø)
.../opensearch/client/slm/SnapshotLifecycleStats.java 0.00% <ø> (ø)
...rch/client/slm/SnapshotRetentionConfiguration.java 0.00% <ø> (ø)
...h/script/mustache/MultiSearchTemplateResponse.java 59.01% <ø> (ø)
...rg/opensearch/index/rankeval/RankEvalResponse.java 81.42% <ø> (-8.58%) ⬇️
...va/org/opensearch/index/rankeval/RankEvalSpec.java 93.85% <ø> (-3.51%) ⬇️
...a/org/opensearch/index/rankeval/RatedDocument.java 82.75% <0.00%> (+1.72%) ⬆️
...va/org/opensearch/index/rankeval/RatedRequest.java 91.79% <ø> (ø)
... and 135 more

... and 420 files with indirect coverage changes

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git]
Compatible components: [https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 29m 55s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 21m 53s

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:


> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/reporting.git with ref: main
Incompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git]
Compatible components: [https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

BUILD SUCCESSFUL in 22m 15s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 3713bcb into opensearch-project:main Aug 8, 2023
@reta reta added the backport 2.x Backport to 2.x branch label Aug 8, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9123-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3713bcb1ab69d18cc990cd36f91f5b5261b71132
# Push it to GitHub
git push --set-upstream origin backport/backport-9123-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9123-to-2.x.

@reta
Copy link
Collaborator

reta commented Aug 8, 2023

@sarthakaggarwal97 could you please send manual backport to 2.x? thank you

sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 9, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 9, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 10, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 11, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 11, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
reta pushed a commit that referenced this pull request Aug 11, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 3713bcb)
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Index Codecs to expose algorithm names as index codec types
5 participants