Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wrapping CollectorManager with profiling during concurrent execution #9129

Merged
merged 2 commits into from
Aug 15, 2023

Add more collectorResult test and work on the PR comments (#9129)

11b24c3
Select commit
Loading
Failed to load commit list.
Merged

Add support for wrapping CollectorManager with profiling during concurrent execution #9129

Add more collectorResult test and work on the PR comments (#9129)
11b24c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 15, 2023 in 0s

71.08% (target 70.00%)

View this Pull Request on Codecov

71.08% (target 70.00%)

Details

Codecov Report

Merging #9129 (11b24c3) into main (4114009) will decrease coverage by 0.11%.
Report is 1 commits behind head on main.
The diff coverage is 40.42%.

@@             Coverage Diff              @@
##               main    #9129      +/-   ##
============================================
- Coverage     71.19%   71.08%   -0.11%     
+ Complexity    57455    57390      -65     
============================================
  Files          4777     4777              
  Lines        270712   270747      +35     
  Branches      39566    39569       +3     
============================================
- Hits         192729   192458     -271     
- Misses        61782    62089     +307     
+ Partials      16201    16200       -1     
Files Changed Coverage Δ
...arch/aggregations/DefaultAggregationProcessor.java 13.04% <0.00%> (-0.92%) ⬇️
...opensearch/search/query/QueryCollectorContext.java 62.33% <0.00%> (-19.02%) ⬇️
.../GlobalAggCollectorManagerWithSingleCollector.java 66.66% <50.00%> (-4.77%) ⬇️
...rch/aggregations/NonGlobalAggCollectorManager.java 91.66% <50.00%> (-8.34%) ⬇️
...nGlobalAggCollectorManagerWithSingleCollector.java 66.66% <50.00%> (-4.77%) ⬇️
...arch/aggregations/AggregationCollectorManager.java 88.00% <100.00%> (+10.22%) ⬆️
...h/aggregations/ConcurrentAggregationProcessor.java 87.87% <100.00%> (+6.62%) ⬆️
...search/aggregations/GlobalAggCollectorManager.java 100.00% <100.00%> (ø)
...profile/query/InternalProfileCollectorManager.java 96.82% <100.00%> (+0.39%) ⬆️

... and 465 files with indirect coverage changes