Fix flaky testCorruptedTranslog test #9139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
sachinpkale and
sohami
as code owners
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
|
Compatibility status: |
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9139 +/- ##
============================================
- Coverage 71.06% 71.05% -0.01%
+ Complexity 57314 57293 -21
============================================
Files 4766 4765 -1
Lines 270453 270478 +25
Branches 39555 39552 -3
============================================
- Hits 192197 192192 -5
- Misses 62045 62072 +27
- Partials 16211 16214 +3
|
kkmr
approved these changes
Aug 12, 2023
dblock
approved these changes
Aug 14, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9139-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f9c728f4f2d50c5d020f46a8658d1a79113bc19e
# Push it to GitHub
git push --set-upstream origin backport/backport-9139-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
|
Looked into manual backporting and see the impacted line is 3.x only, so removed backport tag. |
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
* Fix flaky testCorruptedTranslog test Signed-off-by: Daniel Widdis <widdis@gmail.com> * Simplify by allowing different wrapped exception Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove unnecessary parens: || higher precedence than instanceof Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
* Fix flaky testCorruptedTranslog test Signed-off-by: Daniel Widdis <widdis@gmail.com> * Simplify by allowing different wrapped exception Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove unnecessary parens: || higher precedence than instanceof Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
* Fix flaky testCorruptedTranslog test Signed-off-by: Daniel Widdis <widdis@gmail.com> * Simplify by allowing different wrapped exception Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove unnecessary parens: || higher precedence than instanceof Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
RemoveCorruptedShardDataCommandTeststests for appropriate exceptions on corrupted translogs. In the rare edge case where the corruption occurs in the header where the UUID tracks the engine, the expectedTranslogCorruptedExceptionis caught and rethrown as anEngineCreationFailureExceptionrather than theTranslogExceptionexpected by the test.This change relaxes the test to allow either wrapped exception while testing the same cause.
Related Issues
Fixes #6179
Command reproducing this failure at linked issue; this test passes after this fix.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.