Update the max_slice setting name to max_slice_count

[sohami]

Description

Changing the name of the setting to add _count suffix

Related Issues

Follow-Up of #9107

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• [] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[sohami]

@andrross This is the follow-up PR to change the setting name.

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/opensearch-oci-object-storage.git with ref: 2.x
Skipping compatibility check for https://github.com/opensearch-project/opensearch-oci-object-storage.git
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git]

BUILD SUCCESSFUL in 26m 5s

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

• URL: https://build.ci.opensearch.org/job/gradle-check/22060/
• CommitID: bf66d5b
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #9159 (bf66d5b) into 2.x (e59b21a) will decrease coverage by 0.02%.
Report is 4 commits behind head on 2.x.
The diff coverage is 72.82%.

@@             Coverage Diff              @@
##                2.x    #9159      +/-   ##
============================================
- Coverage     70.81%   70.80%   -0.02%     
- Complexity    57425    57448      +23     
============================================
  Files          4754     4754              
  Lines        271688   271750      +62     
  Branches      40070    40080      +10     
============================================
+ Hits         192408   192411       +3     
- Misses        62717    62826     +109     
+ Partials      16563    16513      -50     

Files Changed	Coverage Δ
.../opensearch/client/indices/CreateIndexRequest.java	74.44% <0.00%> (-3.34%)	⬇️
...opensearch/client/slm/SnapshotLifecyclePolicy.java	0.00% <ø> (ø)
...ch/client/slm/SnapshotLifecyclePolicyMetadata.java	0.00% <ø> (ø)
.../opensearch/client/slm/SnapshotLifecycleStats.java	0.00% <ø> (ø)
...rch/client/slm/SnapshotRetentionConfiguration.java	0.00% <ø> (ø)
...h/script/mustache/MultiSearchTemplateResponse.java	56.25% <ø> (ø)
...rg/opensearch/index/rankeval/RankEvalResponse.java	88.57% <ø> (ø)
...va/org/opensearch/index/rankeval/RankEvalSpec.java	97.36% <ø> (+9.64%)	⬆️
...a/org/opensearch/index/rankeval/RatedDocument.java	81.03% <0.00%> (ø)
...va/org/opensearch/index/rankeval/RatedRequest.java	91.79% <ø> (+6.71%)	⬆️
... and 144 more

... and 431 files with indirect coverage changes