[Remote Store] Fix couple of Remote Store flaky test and use bulk api for ingestion #9190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbafna
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
Compatibility status: |
gbbafna
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale and
sohami
as code owners
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
|
Failed tests in earlier gradle run are not related |
Gradle Check (Jenkins) Run Completed with:
|
linuxpi
approved these changes
Aug 9, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/ReplicaToPrimaryPromotionIT.java
Outdated
Show resolved
Hide resolved
|
LGTM. 1 minor comment. Also, gradle check is failing in UTs and i dont see ITs ran in the logs |
Poojita-Raj
reviewed
Aug 9, 2023
...er/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreBaseIntegTestCase.java
Show resolved
Hide resolved
Poojita-Raj
reviewed
Aug 9, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreIT.java
Show resolved
Hide resolved
|
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
force-pushed
the
flaky-failover
branch
from
18371e8 to
3e42a66
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9190 +/- ##
============================================
- Coverage 71.08% 71.07% -0.01%
+ Complexity 57347 57324 -23
============================================
Files 4770 4770
Lines 270548 270548
Branches 39563 39563
============================================
- Hits 192328 192303 -25
- Misses 61985 62034 +49
+ Partials 16235 16211 -24 |
sachinpkale
approved these changes
Aug 10, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9190-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d06926c863c4a1ad0caf9e87f43fc7c8d6369b8c
# Push it to GitHub
git push --set-upstream origin backport/backport-9190-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
neetikasinghal
pushed a commit
to neetikasinghal/OpenSearch
that referenced
this pull request
Aug 10, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
mch2
pushed a commit
to mch2/OpenSearch
that referenced
this pull request
Aug 11, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit d06926c)
6 tasks
mch2
pushed a commit
to mch2/OpenSearch
that referenced
this pull request
Aug 11, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit d06926c) Signed-off-by: Marc Handalian <handalm@amazon.com>
mch2
pushed a commit
to mch2/OpenSearch
that referenced
this pull request
Aug 11, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit d06926c) Signed-off-by: Marc Handalian <handalm@amazon.com>
linuxpi
pushed a commit
to linuxpi/OpenSearch
that referenced
this pull request
Aug 14, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
linuxpi
pushed a commit
to linuxpi/OpenSearch
that referenced
this pull request
Aug 16, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
… for ingestion (opensearch-project#9190) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two flaky tests :
Updatedresponse as well on new docs creation . Factored in same .Use of bulk indexing API to make Remote ITs faster as well .
Related
Resolves #8658
Resolves #9130
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.