-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Rename RemoteRefreshSegmentPressureSettings and RemoteRefreshSegmentPressureService #9253
[Remote Store] Rename RemoteRefreshSegmentPressureSettings and RemoteRefreshSegmentPressureService #9253
Conversation
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9253 +/- ##
============================================
- Coverage 71.12% 71.08% -0.04%
+ Complexity 57433 57409 -24
============================================
Files 4775 4775
Lines 270700 270740 +40
Branches 39566 39577 +11
============================================
- Hits 192535 192462 -73
- Misses 61958 62119 +161
+ Partials 16207 16159 -48
|
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:
|
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
...er/src/main/java/org/opensearch/action/admin/cluster/remotestore/stats/RemoteStoreStats.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/remote/RemoteSegmentTransferTracker.java
Show resolved
Hide resolved
...t/java/org/opensearch/action/admin/cluster/remotestore/stats/RemoteStoreStatsTestHelper.java
Show resolved
Hide resolved
...c/test/java/org/opensearch/action/admin/cluster/remotestore/stats/RemoteStoreStatsTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall. left one or two minor comments, do take a look.
Gradle Check (Jenkins) Run Completed with:
|
|
Bypassing |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9253-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a25350e7e2f4224d50744a8fb1def65b71f0356
# Push it to GitHub
git push --set-upstream origin backport/backport-9253-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…RefreshSegmentPressureService (opensearch-project#9253) --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
…RefreshSegmentPressureService (opensearch-project#9253) --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
…RefreshSegmentPressureService (opensearch-project#9253) --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
…RefreshSegmentPressureService (opensearch-project#9253) --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
…RefreshSegmentPressureService (opensearch-project#9253) --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…RefreshSegmentPressureService (opensearch-project#9253) --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…RefreshSegmentPressureService (opensearch-project#9253) --------- Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This is an incremental PR for PR #8908
Related Issues
#8311
Check List
Note: This PR only includes refactoring changes
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.