Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Adds attributes to startSpan #9292

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Gaganjuneja
Copy link
Contributor

Description

Backport PR for #9199

Related Issues

Resolves #9197

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Adds attributes to startSpan

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Update Changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds attributes to startSpan

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add java doc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes dependency

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 23m 59s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #9292 (7d90f39) into 2.x (d30199f) will decrease coverage by 0.04%.
Report is 1 commits behind head on 2.x.
The diff coverage is 84.37%.

@@             Coverage Diff              @@
##                2.x    #9292      +/-   ##
============================================
- Coverage     70.80%   70.77%   -0.04%     
- Complexity    57491    57493       +2     
============================================
  Files          4759     4761       +2     
  Lines        271848   271903      +55     
  Branches      40093    40094       +1     
============================================
- Hits         192481   192434      -47     
- Misses        62846    62960     +114     
+ Partials      16521    16509      -12     
Files Changed Coverage Δ
.../opensearch/telemetry/tracing/noop/NoopTracer.java 66.66% <0.00%> (-13.34%) ⬇️
...nsearch/index/shard/CheckpointRefreshListener.java 84.61% <ø> (+7.69%) ⬆️
...earch/index/store/RemoteSegmentStoreDirectory.java 87.70% <0.00%> (ø)
...index/shard/CloseableRetryableRefreshListener.java 76.78% <67.64%> (+3.45%) ⬆️
...rch/telemetry/tracing/OTelAttributesConverter.java 85.71% <85.71%> (ø)
...rch/index/remote/RemoteSegmentTransferTracker.java 89.56% <86.36%> (+0.36%) ⬆️
...search/index/shard/RemoteStoreRefreshListener.java 85.71% <95.45%> (+2.56%) ⬆️
...rg/opensearch/telemetry/tracing/DefaultTracer.java 92.59% <100.00%> (+0.28%) ⬆️
...earch/telemetry/tracing/attributes/Attributes.java 100.00% <100.00%> (ø)
.../telemetry/tracing/runnable/TraceableRunnable.java 100.00% <100.00%> (ø)
... and 2 more

... and 487 files with indirect coverage changes

@reta reta merged commit a3cfccc into opensearch-project:2.x Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants