Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracing Framework] Add proper API annotations #9706

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[Tracing Framework] Add proper API annotations #9706

merged 1 commit into from
Sep 5, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 1, 2023

Description

Add proper API annotations

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Sep 1, 2023

@Gaganjuneja may I ask you to take a look please? thank you.

@reta
[Tracing Framework] Add proper API annotations
029cf8c 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the add.api.annotations branch from 99c363a to 029cf8c Compare September 1, 2023 21:08
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Compatibility status:

Checks if related components are compatible with change 029cf8c

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Compatibility status:

Checks if related components are compatible with change 99c363a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #9706 (029cf8c) into main (dbb868a) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 91.42%.

@@             Coverage Diff              @@
##               main    #9706      +/-   ##
============================================
- Coverage     71.14%   71.11%   -0.03%     
- Complexity    57764    57767       +3     
============================================
  Files          4806     4806              
  Lines        272157   272174      +17     
  Branches      39709    39711       +2     
============================================
- Hits         193630   193569      -61     
- Misses        62276    62359      +83     
+ Partials      16251    16246       -5
Files Changed Coverage Δ
...org/opensearch/telemetry/tracing/AbstractSpan.java 100.00% <ø> (ø)
...pensearch/telemetry/tracing/DefaultScopedSpan.java 100.00% <ø> (ø)
...opensearch/telemetry/tracing/DefaultSpanScope.java 100.00% <ø> (ø)
...rg/opensearch/telemetry/tracing/DefaultTracer.java 93.54% <ø> (ø)
...a/org/opensearch/telemetry/tracing/ScopedSpan.java 100.00% <ø> (ø)
.../org/opensearch/telemetry/tracing/SpanContext.java 100.00% <ø> (ø)
...nsearch/telemetry/tracing/SpanCreationContext.java 100.00% <ø> (ø)
...rg/opensearch/telemetry/tracing/SpanReference.java 100.00% <ø> (ø)
...va/org/opensearch/telemetry/tracing/SpanScope.java 100.00% <ø> (ø)
...earch/telemetry/tracing/attributes/Attributes.java 100.00% <ø> (ø)
... and 16 more

... and 463 files with indirect coverage changes

@reta
Copy link
Collaborator Author

reta commented Sep 5, 2023

@andrross @dblock could you help me folks to get this one in before 2.10 cut? thank you

@reta reta added the v2.10.0 label Sep 5, 2023
dblock
dblock approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only took a cursory look, I imagine this has low chance of breaking anything ;)

@dblock dblock merged commit 19a13f0 into opensearch-project:main Sep 5, 2023
@reta reta added the backport 2.x Backport to 2.x branch label Sep 5, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2023
@github-actions
[Tracing Framework] Add proper API annotations (#9706)
ff785e0 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 19a13f0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 5, 2023
@opensearch-trigger-bot @github-actions
[Tracing Framework] Add proper API annotations (#9706) (#9766)
eb0e76e 
(cherry picked from commit 19a13f0)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@reta @kaushalmahi12
[Tracing Framework] Add proper API annotations (opensearch-project#9706)
5250412 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@reta @brusic
[Tracing Framework] Add proper API annotations (opensearch-project#9706)
6f688e0 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@reta @shiv0408
[Tracing Framework] Add proper API annotations (opensearch-project#9706)
9cc2df5 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaganjuneja Gaganjuneja Gaganjuneja approved these changes

@dblock dblock dblock approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reta @dblock @Gaganjuneja