Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Add support for Remote Translog Store stats in _remotestore/stats/ API #9738

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[Remote Store] Add support for Remote Translog Store stats in _remotestore/stats/ API #9738

merged 2 commits into from
Sep 5, 2023

Conversation

BhumikaSaini-Amazon
Copy link
Contributor

Description

Backport for #9263

Related Issues

#8311

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Remote Store] Add support for Remote Translog Store stats in _remote…
93c71d9 
…store/stats/ API (opensearch-project#9263)

---------

Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Compatibility status:

Checks if related components are compatible with change 93c71d9

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Gradle Check (Jenkins) Run Completed with:

Empty commit to retrigger build
bbfe80b 
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Compatibility status:

Checks if related components are compatible with change bbfe80b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Gradle Check (Jenkins) Run Completed with:

@BhumikaSaini-Amazon BhumikaSaini-Amazon marked this pull request as ready for review September 5, 2023 03:21
@BhumikaSaini-Amazon
Copy link
Contributor Author

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #9738 (bbfe80b) into 2.x (26197f3) will decrease coverage by 0.01%.
Report is 4 commits behind head on 2.x.
The diff coverage is 86.39%.

@@             Coverage Diff              @@
##                2.x    #9738      +/-   ##
============================================
- Coverage     70.98%   70.98%   -0.01%     
+ Complexity    58020    58016       -4     
============================================
  Files          4794     4796       +2     
  Lines        273521   273853     +332     
  Branches      40232    40250      +18     
============================================
+ Hits         194155   194381     +226     
- Misses        62819    62840      +21     
- Partials      16547    16632      +85
Files Changed Coverage Δ
...testore/stats/TransportRemoteStoreStatsAction.java 41.02% <0.00%> (-3.42%) ⬇️
...arch/index/remote/RemoteStorePressureSettings.java 87.09% <ø> (ø)
...ain/java/org/opensearch/indices/IndicesModule.java 98.23% <ø> (-0.02%) ⬇️
...ch/index/remote/RemoteTranslogTransferTracker.java 78.91% <78.91%> (ø)
...search/index/shard/RemoteStoreRefreshListener.java 86.26% <80.00%> (ø)
...rg/opensearch/index/translog/RemoteFsTranslog.java 72.58% <86.20%> (+2.48%) ⬆️
...earch/index/remote/RemoteStorePressureService.java 85.00% <87.50%> (+0.51%) ⬆️
...opensearch/index/remote/RemoteTransferTracker.java 88.57% <88.57%> (ø)
...dex/translog/transfer/TranslogTransferManager.java 78.96% <90.56%> (+2.00%) ⬆️
...h/index/translog/transfer/FileTransferTracker.java 92.98% <90.90%> (-1.62%) ⬇️
... and 6 more

... and 441 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 106c7fb into opensearch-project:2.x Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BhumikaSaini-Amazon @sachinpkale