Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Side nav mds (#1063) #1081

Merged

Conversation

riysaxen-amzn
Copy link
Collaborator

  • persist dataSource when swictching between sideNav

Signed-off-by: Riya Saxena riysaxen@amazon.com

  • persist dataSource when swictching between sideNav

Signed-off-by: Riya Saxena riysaxen@amazon.com

  • persist dataSource when swictching between sideNav

Signed-off-by: Riya Saxena riysaxen@amazon.com

  • fix the CI

Signed-off-by: Riya Saxena riysaxen@amazon.com


Signed-off-by: Riya Saxena riysaxen@amazon.com
Signed-off-by: Riya 69919272+riysaxen-amzn@users.noreply.github.com
(cherry picked from commit 5feef22)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* persist dataSource when swictching between sideNav

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* persist dataSource when swictching between sideNav

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* persist dataSource when swictching between sideNav

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fix the CI

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>
(cherry picked from commit 5feef22)
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.17@83ad06c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             2.17    #1081   +/-   ##
=======================================
  Coverage        ?   48.35%           
=======================================
  Files           ?      237           
  Lines           ?     7063           
  Branches        ?     1038           
=======================================
  Hits            ?     3415           
  Misses          ?     3645           
  Partials        ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riysaxen-amzn riysaxen-amzn merged commit d4862dc into opensearch-project:2.17 Sep 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants