-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a unit test. #576
Merged
AWSHurneyt
merged 5 commits into
opensearch-project:main
from
AWSHurneyt:main_unit_test_fix
Jun 15, 2023
Merged
Fixed a unit test. #576
AWSHurneyt
merged 5 commits into
opensearch-project:main
from
AWSHurneyt:main_unit_test_fix
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 52.82% 52.86% +0.03%
==========================================
Files 212 212
Lines 5594 5594
Branches 782 782
==========================================
+ Hits 2955 2957 +2
+ Misses 2637 2635 -2
Partials 2 2 |
AWSHurneyt
requested review from
lezzago,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
June 15, 2023 18:47
AWSHurneyt
changed the title
Fixed a unit test that started failing after bump to node 18.
Fixed a unit test.
Jun 15, 2023
The cypress workflow is expected to fail on |
5 tasks
lezzago
approved these changes
Jun 15, 2023
amsiglan
reviewed
Jun 15, 2023
amsiglan
reviewed
Jun 15, 2023
public/components/Flyout/flyouts/components/AlertsDashboardFlyoutComponent.js
Show resolved
Hide resolved
amsiglan
reviewed
Jun 15, 2023
public/components/Flyout/flyouts/components/AlertsDashboardFlyoutComponent.js
Show resolved
Hide resolved
amsiglan
reviewed
Jun 15, 2023
public/components/Flyout/flyouts/components/AlertsDashboardFlyoutComponent.test.js
Show resolved
Hide resolved
amsiglan
approved these changes
Jun 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Fixed a unit test that started failing after bump tp node 18. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a unit test that started failing after bump tp node 18. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped lint-staged version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a unit test that started failing after bump tp node 18. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshot. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 353aa25)
lezzago
added a commit
that referenced
this pull request
Jun 30, 2023
* Fixed a unit test that started failing after bump tp node 18. * Fixed a unit test that started failing after bump tp node 18. * Bumped lint-staged version. * Fixed a unit test that started failing after bump tp node 18. * Updated snapshot. --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
added a commit
that referenced
this pull request
Jul 6, 2023
* Fixed a unit test that started failing after bump tp node 18. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a unit test that started failing after bump tp node 18. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped lint-staged version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a unit test that started failing after bump tp node 18. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshot. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 353aa25) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a unit test that started failing.
Issues Resolved
#555
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.