-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context aware alert analysis #996
Merged
amsiglan
merged 22 commits into
opensearch-project:main
from
songkant-aws:context-aware-alert-analysis
Sep 18, 2024
Merged
Context aware alert analysis #996
amsiglan
merged 22 commits into
opensearch-project:main
from
songkant-aws:context-aware-alert-analysis
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
…ization Signed-off-by: Songkan Tang <songkant@amazon.com>
songkant-aws
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
July 15, 2024 05:41
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
…nalysis Signed-off-by: Songkan Tang <songkant@amazon.com>
…nalysis Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
Can some maintainers help review this ticket and add tag 2.17? |
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
amsiglan
reviewed
Aug 28, 2024
amsiglan
reviewed
Aug 28, 2024
amsiglan
reviewed
Aug 28, 2024
amsiglan
reviewed
Aug 28, 2024
amsiglan
reviewed
Aug 28, 2024
amsiglan
reviewed
Aug 28, 2024
Signed-off-by: Songkan Tang <songkant@amazon.com>
amsiglan
previously approved these changes
Sep 3, 2024
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
…formation in additionalInfo Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
…nalysis Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
amsiglan
previously approved these changes
Sep 17, 2024
Signed-off-by: Songkan Tang <songkant@amazon.com>
amsiglan
approved these changes
Sep 18, 2024
riysaxen-amzn
approved these changes
Sep 18, 2024
let's wait for the CI to pass before merging |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
* support date_nanos type Signed-off-by: Hailong Cui <ihailong@amazon.com> * support context aware alert analysis Signed-off-by: Hailong Cui <ihailong@amazon.com> * Register summary generation type of IncontextInsight for alert summarization Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix dashboard unit test failure Signed-off-by: Songkan Tang <songkant@amazon.com> * Make each alert register its own IncontextInsight Signed-off-by: Songkan Tang <songkant@amazon.com> * Enable context aware alert only if feature flag is enabled Signed-off-by: Songkan Tang <songkant@amazon.com> * Avoid unnecessary change and minorly change summary question Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix undefined alert name Signed-off-by: Songkan Tang <songkant@amazon.com> * Pass monitor type to additional info object of contextProvider Signed-off-by: Songkan Tang <songkant@amazon.com> * Address some comments and change feature flag Signed-off-by: Songkan Tang <songkant@amazon.com> * Add assistant capabilities check to control component rendering Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix mismatched unit test snapshots Signed-off-by: Songkan Tang <songkant@amazon.com> * Handle the edge case of multiple indices in search and return more information in additionalInfo Signed-off-by: Songkan Tang <songkant@amazon.com> * Reduce llm context input size by taking topN active alerts Signed-off-by: Songkan Tang <songkant@amazon.com> * Distinguish source data and aggregation that trigger the alert Signed-off-by: Songkan Tang <songkant@amazon.com> * Rename the capability UI rendering flag per assistant plugin change Signed-off-by: Songkan Tang <songkant@amazon.com> * Remove alert sample data per current requirement from context Signed-off-by: Songkan Tang <songkant@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Songkan Tang <songkant@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 6dbdc2e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Sep 19, 2024
* support date_nanos type * support context aware alert analysis * Register summary generation type of IncontextInsight for alert summarization * Fix dashboard unit test failure * Make each alert register its own IncontextInsight * Enable context aware alert only if feature flag is enabled * Avoid unnecessary change and minorly change summary question * Fix undefined alert name * Pass monitor type to additional info object of contextProvider * Address some comments and change feature flag * Add assistant capabilities check to control component rendering * Fix mismatched unit test snapshots * Handle the edge case of multiple indices in search and return more information in additionalInfo * Reduce llm context input size by taking topN active alerts * Distinguish source data and aggregation that trigger the alert * Rename the capability UI rendering flag per assistant plugin change * Remove alert sample data per current requirement from context --------- (cherry picked from commit 6dbdc2e) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Songkan Tang <songkant@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Sep 19, 2024
* support date_nanos type Signed-off-by: Hailong Cui <ihailong@amazon.com> * support context aware alert analysis Signed-off-by: Hailong Cui <ihailong@amazon.com> * Register summary generation type of IncontextInsight for alert summarization Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix dashboard unit test failure Signed-off-by: Songkan Tang <songkant@amazon.com> * Make each alert register its own IncontextInsight Signed-off-by: Songkan Tang <songkant@amazon.com> * Enable context aware alert only if feature flag is enabled Signed-off-by: Songkan Tang <songkant@amazon.com> * Avoid unnecessary change and minorly change summary question Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix undefined alert name Signed-off-by: Songkan Tang <songkant@amazon.com> * Pass monitor type to additional info object of contextProvider Signed-off-by: Songkan Tang <songkant@amazon.com> * Address some comments and change feature flag Signed-off-by: Songkan Tang <songkant@amazon.com> * Add assistant capabilities check to control component rendering Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix mismatched unit test snapshots Signed-off-by: Songkan Tang <songkant@amazon.com> * Handle the edge case of multiple indices in search and return more information in additionalInfo Signed-off-by: Songkan Tang <songkant@amazon.com> * Reduce llm context input size by taking topN active alerts Signed-off-by: Songkan Tang <songkant@amazon.com> * Distinguish source data and aggregation that trigger the alert Signed-off-by: Songkan Tang <songkant@amazon.com> * Rename the capability UI rendering flag per assistant plugin change Signed-off-by: Songkan Tang <songkant@amazon.com> * Remove alert sample data per current requirement from context Signed-off-by: Songkan Tang <songkant@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Songkan Tang <songkant@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context aware alert analysis implementation in alerts dashboard by leveraging existing IncontextInsight 'GeneratePopover' component
In-context prompting for alerts entry point:
In-context prompting generating process:
In-context prompting showing summary result with option to continue the conversation in chat:
Issues Resolved
#995
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.