-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Acknowledge Alert Request class loader issue #618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate as AckAlertRequest Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
sbcd90
approved these changes
Oct 20, 2022
lezzago
approved these changes
Oct 20, 2022
Failure is from
which is not related to this PR this failure arises from common utils PR: fix security-analytics alerting findings api integration |
sbcd90
pushed a commit
to sbcd90/alerting
that referenced
this pull request
Nov 2, 2022
…ate as AckAlertRequest (opensearch-project#618) (opensearch-project#619) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 2005185) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change transport ack alerts action to accept Action Request and recreate as AckAlertRequest to fix Acknowledge Alert Request class loader issue
Solving the same issue we faced earlier with notifications for ack alerts flow : opensearch-project/common-utils#37
Signed-off-by: Surya Sashank Nistala snistala@amazon.com