-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support historical analysis for HC detector #104
support historical analysis for HC detector #104
Conversation
Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
Codecov Report
@@ Coverage Diff @@
## single-flow-development-rc1 #104 +/- ##
=================================================================
- Coverage 79.12% 70.07% -9.06%
+ Complexity 2700 2523 -177
=================================================================
Files 243 244 +1
Lines 11244 11895 +651
Branches 1033 1089 +56
=================================================================
- Hits 8897 8335 -562
- Misses 1917 3137 +1220
+ Partials 430 423 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New comments based on our discussions on Friday.
src/main/java/org/opensearch/ad/transport/ForwardADTaskTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/transport/ForwardADTaskTransportAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/transport/ForwardADTaskTransportAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/transport/ForwardADTaskTransportAction.java
Show resolved
Hide resolved
Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
4f2c24f
to
fd028d6
Compare
resolved all of open comments from me. Please address the left over comments from the old PR: #58 |
Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
c2911b6
to
be452a4
Compare
src/main/java/org/opensearch/ad/transport/ForwardADTaskTransportAction.java
Show resolved
Hide resolved
Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
30b7e8d
to
c4d568e
Compare
Thanks Kaituo. To save some effort, I just replied most other comments on the old PR directly. You can check my replies on the old PR and comment more on this PR if have new questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns from my side. Thanks for the changes.
…ld HC detector This change contains PR: opensearch-project#33 opensearch-project#42 opensearch-project#48 opensearch-project#51 opensearch-project#104 opensearch-project#123 opensearch-project#130 opensearch-project#131 opensearch-project#132 Signed-off-by: Yaliang Wu <ylwu@amazon.com>
…eld HC detector This change contains PR: opensearch-project#33 opensearch-project#42 opensearch-project#48 opensearch-project#51 opensearch-project#104 opensearch-project#123 opensearch-project#130 opensearch-project#131 opensearch-project#132
…eld HC detector This change contains PR: opensearch-project#33 opensearch-project#42 opensearch-project#48 opensearch-project#51 opensearch-project#104 opensearch-project#123 opensearch-project#130 opensearch-project#131 opensearch-project#132 Signed-off-by: Yaliang Wu <ylwu@amazon.com>
* tune data model for unified flow Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support unified flow for single entity detector Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add realtime task Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support preview with detector directly Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support historical analysis for HC detector (#104) * support run historical analysis for HC detector Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more javadoc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments: rename method, remove comments etc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more comments for task action Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments from old CR: mainly renaming and add more comments Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * support HC task profiles in profile API;error handling (#123) * support HC task profiles in profile API;error handling Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add init progress of realtime task (#130) * add init progress of realtime task * add realtime task cache * remove DetectionStateHandler, will track error in realtime task * add more comments * add delete anomaly results API (#131) Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain running historical task in hourly cron (#132) * maintain running historical task in hourly cron Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain realtime tasks * address comments Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
* tune data model for unified flow Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support unified flow for single entity detector Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add realtime task Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support preview with detector directly Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support historical analysis for HC detector (opensearch-project#104) * support run historical analysis for HC detector Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more javadoc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments: rename method, remove comments etc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more comments for task action Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments from old CR: mainly renaming and add more comments Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * support HC task profiles in profile API;error handling (opensearch-project#123) * support HC task profiles in profile API;error handling Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add init progress of realtime task (opensearch-project#130) * add init progress of realtime task * add realtime task cache * remove DetectionStateHandler, will track error in realtime task * add more comments * add delete anomaly results API (opensearch-project#131) Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain running historical task in hourly cron (opensearch-project#132) * maintain running historical task in hourly cron Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain realtime tasks * address comments Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
* tune data model for unified flow Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support unified flow for single entity detector Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add realtime task Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support preview with detector directly Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support historical analysis for HC detector (opensearch-project#104) * support run historical analysis for HC detector Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more javadoc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments: rename method, remove comments etc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more comments for task action Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments from old CR: mainly renaming and add more comments Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * support HC task profiles in profile API;error handling (opensearch-project#123) * support HC task profiles in profile API;error handling Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add init progress of realtime task (opensearch-project#130) * add init progress of realtime task * add realtime task cache * remove DetectionStateHandler, will track error in realtime task * add more comments * add delete anomaly results API (opensearch-project#131) Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain running historical task in hourly cron (opensearch-project#132) * maintain running historical task in hourly cron Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain realtime tasks * address comments Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
* tune data model for unified flow Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support unified flow for single entity detector Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add realtime task Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support preview with detector directly Signed-off-by: Yaliang Wu <ylwu@amazon.com> * support historical analysis for HC detector (#104) * support run historical analysis for HC detector Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more javadoc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments: rename method, remove comments etc Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * add more comments for task action Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * address comments from old CR: mainly renaming and add more comments Signed-off-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com> * support HC task profiles in profile API;error handling (#123) * support HC task profiles in profile API;error handling Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add init progress of realtime task (#130) * add init progress of realtime task * add realtime task cache * remove DetectionStateHandler, will track error in realtime task * add more comments * add delete anomaly results API (#131) Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain running historical task in hourly cron (#132) * maintain running historical task in hourly cron Signed-off-by: Yaliang Wu <ylwu@amazon.com> * maintain realtime tasks * address comments Co-authored-by: Yaliang Wu <ylwu@dev-dsk-ylwu-2c-e500d1cf.us-west-2.amazon.com>
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
Support historical analysis for HC detector. For single entity detector, we just need to create one AD task as it has only one ML model. For HC detector, AD will run separate ML model for each entity. So we will create individual task for each entity. And we will have one detector level task to track overall state like progress. Will save detector level task id as parent task id in entity task.
The main steps for HC detector historical analysis:
ADTaskManager#getAdEntityTaskAction
for details.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.