don't replace detector user when update #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
added
bug
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
============================================
+ Coverage 75.97% 76.35% +0.37%
- Complexity 2886 2896 +10
============================================
Files 264 264
Lines 12435 12431 -4
Branches 1222 1221 -1
============================================
+ Hits 9448 9492 +44
+ Misses 2478 2421 -57
- Partials 509 518 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
spbjss
reviewed
Jul 14, 2021
| @@ -102,7 +102,7 @@ protected void doExecute(Task task, AnomalyDetectorJobRequest request, ActionLis | |||
| detectorId, | |||
| filterByEnabled, | |||
| listener, | |||
| () -> executeDetector(listener, detectorId, seqNo, primaryTerm, rawPath, requestTimeout, user), | |||
| (anomalyDetector) -> executeDetector(listener, detectorId, seqNo, primaryTerm, rawPath, requestTimeout, user), | |||
There was a problem hiding this comment.
Curiously, it seems the anomalyDetector was not used in the executeDetector method?
There was a problem hiding this comment.
Yes, actually the executeDetector will get detector with detectorId. This PR is mainly to fix the security issue. Will refactor code in separate PR to reuse detector rather than query it again. Will add some TODO to make it clear
There was a problem hiding this comment.
Create an issue to track this #127
saratvemulapalli
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Had a chat with @ylwu-amzn , not really happy with the path from the customer perspective.
But I agree security comes first.
Thanks for the changes, they look good to me!
ohltyler
pushed a commit
to ohltyler/anomaly-detection-2
that referenced
this pull request
Sep 1, 2021
* don't replace detector user when update Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix wrong doc link
ohltyler
pushed a commit
to ohltyler/anomaly-detection-2
that referenced
this pull request
Sep 1, 2021
* don't replace detector user when update Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix wrong doc link
ohltyler
pushed a commit
that referenced
this pull request
Sep 1, 2021
* don't replace detector user when update Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix wrong doc link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
In current implementation, when user update detector, we will replace detector user as current user. In some cases, it may cause detector creator lose access of detector. Check more details in #124
Based on discussion with @skkosuri-amzn and PM, we plan to fix this issue quickly by blocking replacing detector user when update. User can't update detector user after creation.
Issues Resolved
#124
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.