Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Prevent resetting latest flag of real-time when starting historical analysis #1288

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport afd5da9 from #1287.

…g historical analysis (#1287)

This PR addresses a bug where starting a historical analysis after a real-time analysis on the same detector caused the real-time task’s latest flag to be incorrectly reset to false by the historical run.

The fix ensures that only the latest flags of the same analysis type are reset:
* Real-time analysis will only reset the latest flag of previous real-time analyses.
* Historical analysis will only reset the latest flag of previous historical analyses.

This PR also updated recencyEmphasis to have a minimum value of 2, aligning with RCF requirements.

Testing:
- Added an integration test to reproduce the bug and verified the fix.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit afd5da9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@amitgalitz amitgalitz merged commit 48b56eb into 2.x Sep 2, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant