Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing user to getLatestDataTime call #1296

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

amitgalitz
Copy link
Member

Description

Changed getLatestDataTime so we pass the correct user so we have the right user info when querying remote indices, otherwise we get a failure like:

nested: RemoteTransportException[[35692e6c255f][172.22.0.4:9300][indices:data/read/search]]; nested: OpenSearchSecurityException[No user found for indices:data/read/search];

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (3f0fc8c) to head (9f4cbb9).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...pensearch/timeseries/feature/SearchFeatureDao.java 63.63% 3 Missing and 1 partial ⚠️
...ies/rest/handler/ModelValidationActionHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1296      +/-   ##
============================================
+ Coverage     71.83%   77.49%   +5.66%     
- Complexity     4898     5443     +545     
============================================
  Files           518      533      +15     
  Lines         22879    23324     +445     
  Branches       2245     2311      +66     
============================================
+ Hits          16434    18075    +1641     
+ Misses         5410     4188    -1222     
- Partials       1035     1061      +26     
Flag Coverage Δ
plugin 77.49% <70.58%> (+5.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../rest/handler/AbstractTimeSeriesActionHandler.java 95.45% <100.00%> (+30.64%) ⬆️
...h/timeseries/rest/handler/IntervalCalculation.java 93.20% <ø> (+93.20%) ⬆️
...h/timeseries/rest/handler/LatestTimeRetriever.java 87.83% <100.00%> (+87.83%) ⬆️
...earch/timeseries/util/CrossClusterConfigUtils.java 90.47% <ø> (ø)
...ies/rest/handler/ModelValidationActionHandler.java 74.26% <0.00%> (+74.26%) ⬆️
...pensearch/timeseries/feature/SearchFeatureDao.java 80.06% <63.63%> (-2.67%) ⬇️

... and 101 files with indirect coverage changes

@kaituo
Copy link
Collaborator

kaituo commented Sep 5, 2024

Can you add a test to reproduce the bug? If it is too time consuming, we can do it after cut off.

@amitgalitz
Copy link
Member Author

Can you add a test to reproduce the bug? If it is too time consuming, we can do it after cut off.

It only occurs on remote index, not 100% sure on best way to have integration with remote clusters, might take me longer then cut off

@amitgalitz amitgalitz merged commit 90a6fc3 into opensearch-project:main Sep 5, 2024
20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
(cherry picked from commit 90a6fc3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
(cherry picked from commit 90a6fc3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit 90a6fc3)

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit 90a6fc3)

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants