-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing user to getLatestDataTime call #1296
Conversation
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
78770cf
to
9f4cbb9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
============================================
+ Coverage 71.83% 77.49% +5.66%
- Complexity 4898 5443 +545
============================================
Files 518 533 +15
Lines 22879 23324 +445
Branches 2245 2311 +66
============================================
+ Hits 16434 18075 +1641
+ Misses 5410 4188 -1222
- Partials 1035 1061 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Can you add a test to reproduce the bug? If it is too time consuming, we can do it after cut off. |
It only occurs on remote index, not 100% sure on best way to have integration with remote clusters, might take me longer then cut off |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit 90a6fc3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit 90a6fc3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 90a6fc3) Signed-off-by: Amit Galitzky <amgalitz@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 90a6fc3) Signed-off-by: Amit Galitzky <amgalitz@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Changed getLatestDataTime so we pass the correct user so we have the right user info when querying remote indices, otherwise we get a failure like:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.