[Backport 2.x] Not blocking detector creation on unknown feature validation error #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitgalitz
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1371 +/- ##
=========================================
Coverage 80.14% 80.15%
Complexity 5684 5684
=========================================
Files 533 533
Lines 23435 23439 +4
Branches 2334 2334
=========================================
+ Hits 18783 18788 +5
+ Misses 3550 3549 -1
Partials 1102 1102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…pensearch-project#1366) * don't fail on unknown exception Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * fixing test Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * order of needed permissions is changed on latest security version or at least not always consistent now Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * refactor customNodeclient Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
force-pushed
the
port-2-x-1366
branch
from
056f06f to
8992d78
Compare
owaiskazi19
approved these changes
Nov 26, 2024
joshpalis
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting #1366 to 2.x
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.