Adding external property customDistributionUrl to let developer override default distribution Download url

[Rishikesh1159]

Signed-off-by: Rishikesh1159 rishireddy1159@gmail.com

Description

This PR adds external property "customDistributionUrl" which can be used to override default distribution download url

Issues Resolved

#381

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ylwu-amzn]

BTW, will this customDistributionUrl work on 1.3.0? I tried ./gradlew integTest -DcustomDistributionUrl="https://ci.opensearch.org/ci/dbc/bundle-build/1.2.0/1127/linux/x64/dist/opensearch-1.2.0-linux-x64.tar.gz" , seems the integ cluster is still 1.3.0

[Rishikesh1159]

@ylwu-amzn sorry the I had to revert my PR in opensearch repo which actually makes his change possible. So, iI could not get this change done in 1.3 version.

[Rishikesh1159]

Few days back I released a new PR in opensearch repo which will make this change work. But I will have to wait until 1.3 release to backport my PR to 1.x branch in opensearch repo. I will update this PR once I backport my changes to 1.x in opensarch repo and then we can use different versions by passing a custom URL from plugins.

[amitgalitz]

Hi @Rishikesh1159 could you provide some update on this PR?

[Rishikesh1159]

Sorry @amitgalitz @ylwu-amzn for the delay, I forgot about this PR. My change got merged in main and it works with all plugins. We just need to document that this feature is available and how to use it to users, which I did in latest commit. Other than that no changes are necessary in this repo for this feature to work.

[codecov-commenter]

Codecov Report

Merging #380 (d3f412c) into main (f630c8f) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head d3f412c differs from pull request most recent head 3685923. Consider uploading reports for the commit 3685923 to get more accurate results

@@             Coverage Diff              @@
##               main     #380      +/-   ##
============================================
- Coverage     79.07%   79.04%   -0.04%     
+ Complexity     4213     4210       -3     
============================================
  Files           296      296              
  Lines         17686    17686              
  Branches       1880     1880              
============================================
- Hits          13986    13980       -6     
- Misses         2805     2808       +3     
- Partials        895      898       +3     

Flag	Coverage Δ
plugin	79.04% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rch/ad/transport/AnomalyResultTransportAction.java	80.13% <0.00%> (-0.69%)	⬇️
.../main/java/org/opensearch/ad/ml/CheckpointDao.java	69.55% <0.00%> (-0.65%)	⬇️
...opensearch/ad/indices/AnomalyDetectionIndices.java	72.12% <0.00%> (-0.19%)	⬇️

[amitgalitz]

Thanks for adding this

[saratvemulapalli]

@Rishikesh1159 @amitgalitz whats needed here? Another +1 ?

[amitgalitz]

On my end, yes, this is just added documentation for something that was added and I verified in the past it works. If nothing changed on @Rishikesh1159 side then just needs another approval.

[saratvemulapalli]

@amitgalitz I've approved it. Could you merge them if you are good?