-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions] Fish out Create Detector and remove everything else for extensions. #623
[Feature/extensions] Fish out Create Detector and remove everything else for extensions. #623
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although it's hard to review a negative diff. Makes me wonder if we shouldn't just start with a fresh repo and bring things over that we want to keep.
Looking for one more pair of eyes. |
+1 to this. @saratvemulapalli WDYT? |
Should we merge #619 before this? |
@dbwiddis @owaiskazi19 The problem maintain a fresh piece of code is that we have to keep understanding the diff between I would propose keeping this branch with all commented code and when we start integrating the SDK we can pull the fresh pieces of code. What do you guys think? |
Makes sense. Thanks for showing the big picture here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @saratvemulapalli . I don't have the green 😞
Well more commits will earn you the green :) |
Thats a good point. |
Description
Commenting out code for all features of AD except create detector.
I've manually tested and create detector still works.
Manual Test
Note I'll mark the PR in draft state to comment out the tests. Obviously a lot of tests would fail :)Everything works!!
Issues Resolved
Closes opensearch-project/opensearch-sdk-java#20
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.