Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run BWC tests in distribution level #766

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Dec 20, 2022

Description

Add option to run BWC tests in distribution level, which is running tests in the test cluster with latest distribution bundle installed and all plugins (included in the latest manifest) present.

The command to run BWC tests in distribution level would be ./gradlew bwcTestSuite -Dtests.security.manager=false -PcustomDistributionDownloadType=bundle
If property customDistributionDownloadType is not set nor set to bundle, the BWC tests would be default to run in plugins level as previously configured.

Issues Resolved

Part of opensearch-project/opensearch-build#2870

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team December 20, 2022 20:38
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh self-assigned this Dec 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #766 (b6af132) into 2.x (8ce4493) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head b6af132 differs from pull request most recent head 8643fc6. Consider uploading reports for the commit 8643fc6 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #766      +/-   ##
============================================
+ Coverage     79.43%   79.49%   +0.06%     
- Complexity     4293     4295       +2     
============================================
  Files           302      302              
  Lines         17956    17956              
  Branches       1906     1906              
============================================
+ Hits          14263    14274      +11     
+ Misses         2790     2776      -14     
- Partials        903      906       +3     
Flag Coverage Δ
plugin 79.49% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 88.88% <0.00%> (-1.24%) ⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 81.76% <0.00%> (-0.76%) ⬇️
...rch/ad/transport/AnomalyResultTransportAction.java 81.10% <0.00%> (+0.23%) ⬆️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 77.80% <0.00%> (+0.75%) ⬆️
.../main/java/org/opensearch/ad/NodeStateManager.java 76.47% <0.00%> (+1.30%) ⬆️
...rch/ad/transport/ForwardADTaskTransportAction.java 97.45% <0.00%> (+3.38%) ⬆️

@ohltyler
Copy link
Member

ohltyler commented Dec 21, 2022

Can this be targeted to main and backported to 2.x? Or rather, will there be a separate PR with 2.x BWC versions for main?

build.gradle Show resolved Hide resolved
@zelinh
Copy link
Member Author

zelinh commented Dec 21, 2022

Can this be targeted to main and backported to 2.x? Or rather, will there be a separate PR with 2.x BWC versions for main?

Yeah currently the distribution build for our 3.0.0 are failing and we don't have a stable bundle to test on. So I'm targeting to 2.5 version for now. I could draft a new PR to onboard on main when we getting close.

@ohltyler
Copy link
Member

Can this be targeted to main and backported to 2.x? Or rather, will there be a separate PR with 2.x BWC versions for main?

Yeah currently the distribution build for our 3.0.0 are failing and we don't have a stable bundle to test on. So I'm targeting to 2.5 version for now. I could draft a new PR to onboard on main when we getting close.

Got it. I think as long as this is tracked on the infra side this is fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants