[Feature/extensions] Updated imports for xcontent #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
owaiskazi19
changed the title
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Merged
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
ryanbogan
approved these changes
Feb 24, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## feature/extensions #817 +/- ##
========================================================
- Coverage 49.17% 45.60% -3.57%
+ Complexity 2630 2458 -172
========================================================
Files 297 297
Lines 17115 17115
Branches 1843 1843
========================================================
- Hits 8416 7806 -610
- Misses 8089 8739 +650
+ Partials 610 570 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshpalis
approved these changes
Feb 27, 2023
dbwiddis
reviewed
Feb 27, 2023
| 'org.opensearch.ad.transport.AnomalyResultAction', | ||
| 'org.opensearch.ad.transport.CronNodeResponse', | ||
| 'org.opensearch.ad.transport.CronResponse', | ||
| 'org.opensearch.ad.transport.AnomalyResultResponse' |
There was a problem hiding this comment.
Are all these exclusions part of this PR or just left over from a merge commit (i.e., fixed by rebase)?
There was a problem hiding this comment.
They are the part of this PR. Updating imports caused failure for few test cases, the functionality of which isn't implemented anyway.
dbwiddis
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates xcontent imports changed by opensearch-project/OpenSearch#5902
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.