Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of mapping types #119

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Mar 29, 2022

Description

Remove usage of mapping types
Piggybacking on @peterzhuamazon's #118 for the latest version of OS as 2.0.0-SNAPSHOT wasn't breaking build and issue was not reproducible.

Issues Resolved

#98

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon and others added 3 commits March 28, 2022 21:34
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep requested a review from a team as a code owner March 29, 2022 11:27
@eirsep eirsep force-pushed the remove-mapping-types branch 2 times, most recently from e7e65a6 to 683f7e8 Compare March 29, 2022 13:46
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@1c28a08). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage        ?   83.75%           
  Complexity      ?      555           
=======================================
  Files           ?       61           
  Lines           ?     2050           
  Branches        ?      146           
=======================================
  Hits            ?     1717           
  Misses          ?      227           
  Partials        ?      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c28a08...54fdbe2. Read the comment docs.

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep force-pushed the remove-mapping-types branch from 54fdbe2 to 8018cfc Compare March 29, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants