Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed Keys Response param added in Get Asynchronous Search API #49

Closed
wants to merge 1 commit into from

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Oct 12, 2021

Signed-off-by: Surya Nistala snistala@amazon.com

Description

Adds the typed_keys response param in Get Asynchronous Search API. Now we can pass typed_keys param in both Submit and Get Asynchronous Search APIs and plugin will honor it.

Issues Resolved

#46

Testing

  1. typed_keys is false
% curl "http://localhost:9200/_opendistro/_asynchronous_search/$aid?pretty"                   
{
  "id" : "FnA1c1ZlQmFqUVMyRFFXb3c1NnZyT1EDMTgxFDJOa0FkSHdCTHJLMnhuNVVBOUhMATE=",
  "state" : "STORE_RESIDENT",
  "start_time_in_millis" : 1634033730515,
  "expiration_time_in_millis" : 1634120130515,
  "response" : {
    "took" : 4,
    "timed_out" : false,
    "_shards" : {
      "total" : 1,
      "successful" : 1,
      "skipped" : 0,
      "failed" : 0
    },
    "hits" : {
      "total" : {
        "value" : 6,
        "relation" : "eq"
      },
      "max_score" : null,
      "hits" : [ ]
    },
    "aggregations" : {
      "unique_skus" : {
        "value" : 0
      }
    }
  }
}

  1. 'typed_keys' is true
% curl "http://localhost:9200/_opendistro/_asynchronous_search/$aid?pretty&typed_keys=true"
{
  "id" : "FnA1c1ZlQmFqUVMyRFFXb3c1NnZyT1EDMTgxFDJOa0FkSHdCTHJLMnhuNVVBOUhMATE=",
  "state" : "STORE_RESIDENT",
  "start_time_in_millis" : 1634033730515,
  "expiration_time_in_millis" : 1634120130515,
  "response" : {
    "took" : 4,
    "timed_out" : false,
    "_shards" : {
      "total" : 1,
      "successful" : 1,
      "skipped" : 0,
      "failed" : 0
    },
    "hits" : {
      "total" : {
        "value" : 6,
        "relation" : "eq"
      },
      "max_score" : null,
      "hits" : [ ]
    },
    "aggregations" : {
      "cardinality#unique_skus" : {
        "value" : 0
      }
    }
  }
}

Check List

  • [Y] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Surya Nistala <snistala@amazon.com>
private static final Set<String> RESPONSE_PARAMS;
static final Set<String> RESPONSE_PARAMS;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it to a base Action?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Surya
Let add a test case here and also include states other than STORE_RESIDENT

@dblock
Copy link
Member

dblock commented Apr 19, 2022

What should we do with this PR?

@bbarani
Copy link
Member

bbarani commented Sep 25, 2023

Anyone looking in to this PR? @eirsep @Bukhtawar @bharath-techie

@dblock
Copy link
Member

dblock commented Jul 1, 2024

Looks like there was no followup on the test ask, closing as stalled.

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

@dblock dblock closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants