-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds test and build workflow for windows #74
Conversation
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage ? 82.75%
Complexity ? 549
=======================================
Files ? 61
Lines ? 2058
Branches ? 146
=======================================
Hits ? 1703
Misses ? 247
Partials ? 108 Continue to review full report at Codecov.
|
.github/workflows/build.yml
Outdated
# This step uses the checkout Github action: https://github.com/actions/checkout | ||
- name: Checkout Branch | ||
uses: actions/checkout@v2 | ||
# This is a hack, but this step creates a link to the X: mounted drive, which makes the path short enough to work on Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you get without this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
.github/workflows/build.yml
Outdated
windows-build: | ||
# Job name | ||
name: Build Asynchronous Search | ||
# This job runs on Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
* Upgrades plugin to 1.3.0-SNAPSHOT (#73) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Adds test and build workflow for windows (#74) * Adds test and build workflow for windows Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Adds test and build workflow for mac os (#76) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Updating workflows to run on all branches (#80) Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Surya Sashank Nistala snistala@amazon.com
Description
Adds test and build workflow for windows OS
Issues Resolved
#51
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.