Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test and build workflow for windows #74

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Dec 7, 2021

Signed-off-by: Surya Sashank Nistala snistala@amazon.com

Description

Adds test and build workflow for windows OS

Issues Resolved

#51

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep requested a review from a team as a code owner December 7, 2021 15:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@a6a40c2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage        ?   82.75%           
  Complexity      ?      549           
=======================================
  Files           ?       61           
  Lines           ?     2058           
  Branches        ?      146           
=======================================
  Hits            ?     1703           
  Misses          ?      247           
  Partials        ?      108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a40c2...da182e0. Read the comment docs.

# This step uses the checkout Github action: https://github.com/actions/checkout
- name: Checkout Branch
uses: actions/checkout@v2
# This is a hack, but this step creates a link to the X: mounted drive, which makes the path short enough to work on Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you get without this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep requested a review from dblock December 7, 2021 18:05
windows-build:
# Job name
name: Build Asynchronous Search
# This job runs on Linux.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep merged commit 9aeca94 into opensearch-project:main Dec 8, 2021
eirsep added a commit that referenced this pull request Dec 15, 2021
* Upgrades plugin to 1.3.0-SNAPSHOT (#73)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* Adds test and build workflow for windows (#74)

* Adds test and build workflow for windows

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* Adds test and build workflow for mac os (#76)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* Updating workflows to run on all branches (#80)

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants