Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused properties file. #85

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 18, 2021

Signed-off-by: dblock dblock@dblock.org

Description

This file is misleading and is not used. The version of the plugin is derived from -Dopensearch.version. That mechanism prevents a conflict between the version in gradle.properties and the OpenSearch version passed in.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock requested a review from a team as a code owner December 18, 2021 14:03
@codecov-commenter
Copy link

Codecov Report

Merging #85 (425ad4b) into main (af3d143) will increase coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
+ Coverage     82.94%   83.62%   +0.68%     
- Complexity      552      555       +3     
============================================
  Files            61       61              
  Lines          2058     2058              
  Branches        146      146              
============================================
+ Hits           1707     1721      +14     
+ Misses          245      229      -16     
- Partials        106      108       +2     
Impacted Files Coverage Δ
...ersistence/AsynchronousSearchPersistenceModel.java 76.74% <0.00%> (-2.33%) ⬇️
...ous/listener/AsynchronousSearchTimeoutWrapper.java 86.20% <0.00%> (ø)
...anagement/AsynchronousSearchManagementService.java 76.86% <0.00%> (+1.49%) ⬆️
...text/permits/AsynchronousSearchContextPermits.java 100.00% <0.00%> (+8.51%) ⬆️
...ous/processor/AsynchronousSearchPostProcessor.java 76.62% <0.00%> (+11.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3d143...425ad4b. Read the comment docs.

@dblock dblock merged commit ef0fc79 into opensearch-project:main Dec 18, 2021
@dblock dblock deleted the delete-properties branch December 18, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants