Add missing ctx variables #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partlov
force-pushed
the
bug/fix_missing_ctx_variables
branch
2 times, most recently
from
0a19c74 to
7cba7ae
Compare
partlov
changed the title
partlov
changed the title
partlov
force-pushed
the
bug/fix_missing_ctx_variables
branch
11 times, most recently
from
03560d9 to
5868ab4
Compare
This was referenced Nov 15, 2022
Closed
1 task
|
We need to rebase. If the external contributor can't update this, someone from the Alerting team will take it |
- Issue opensearch-project/alerting#200 Signed-off-by: Petar Partlov <partlov@gmail.com>
partlov
force-pushed
the
bug/fix_missing_ctx_variables
branch
from
5868ab4 to
ccddedf
Compare
Rebased |
|
@partlov can we resolve the conflicts |
|
@riysaxen-amzn Looks like a very old PR, make you can help rebase it and get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Partlov partlov@gmail.com
Description
Added missing fields to ctx so content is aligned with documentation and our plans.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.