Skip to content

Commit

Permalink
side navigation changes for notifications (#222) (#230)
Browse files Browse the repository at this point in the history
* side navigation changes for notifications



* fix jest tests



* navLinks changes



* fixed the issues



* fixed the issues



* addressed the comments



* addressed the comments



* Update public/plugin.ts



---------




(cherry picked from commit 9e6066a)

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
  • Loading branch information
3 people authored Jul 30, 2024
1 parent 306d149 commit f04d2ea
Show file tree
Hide file tree
Showing 3 changed files with 268 additions and 199 deletions.
4 changes: 2 additions & 2 deletions public/application.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import { HashRouter as Router, Route } from 'react-router-dom';
import { AppMountParameters, CoreStart } from '../../../src/core/public';
import { CoreServicesContext } from './components/coreServices';
import Main from './pages/Main';
import { NotificationService } from './services';
import { ServicesContext } from './services/services';
import { DataSourceManagementPluginSetup } from '../../../src/plugins/data_source_management/public';
import { AppPluginStartDependencies } from "./types";

Expand All @@ -19,6 +17,7 @@ export const renderApp = (
params: AppMountParameters,
dataSourceManagement: DataSourceManagementPluginSetup,
pluginStartDependencies: AppPluginStartDependencies,
defaultRoute?: string,
) => {

ReactDOM.render(
Expand All @@ -31,6 +30,7 @@ export const renderApp = (
multiDataSourceEnabled={!!pluginStartDependencies.dataSource}
dataSourceManagement={dataSourceManagement}
http={coreStart.http} // Pass http as a prop
defaultRoute={defaultRoute}
/>
</CoreServicesContext.Provider>
)}
Expand Down
Loading

0 comments on commit f04d2ea

Please sign in to comment.