Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWSHurneyt as maintainer #177

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Hailong-am
Copy link
Collaborator

Description

Add @AWSHurneyt as maintainer

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (822dcf1) to head (c6cdc49).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   86.70%   86.70%           
=======================================
  Files          52       52           
  Lines        1497     1497           
  Branches      373      373           
=======================================
  Hits         1298     1298           
  Misses        196      196           
  Partials        3        3           
Flag Coverage Δ
dashboards-notifications 86.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit 7ed9bac into opensearch-project:main Mar 25, 2024
8 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-177-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7ed9bacd0192a530dc4844c3315d8cbe16955ebc
# Push it to GitHub
git push --set-upstream origin backport/backport-177-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-177-to-2.x.

riysaxen-amzn pushed a commit to riysaxen-amzn/dashboards-notifications that referenced this pull request Apr 26, 2024
Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 7ed9bac)
AWSHurneyt pushed a commit that referenced this pull request Apr 26, 2024
* bumping up the opensearch dashboards versions

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* Add AWSHurneyt as maintainer (#177)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 7ed9bac)

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants