New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page header #236

Merged

AWSHurneyt merged 23 commits into opensearch-project:main from riysaxen-amzn:page-header

Aug 20, 2024

Collaborator

riysaxen-amzn commented Aug 14, 2024 •

edited

Loading

Description

Page-header changes as per new UX

Issues Resolved

recording.mov

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

riysaxen-amzn requested review from xluo-aws, gaobinlong, Hailong-am, SuZhou-Joe, zhichao-aws, yuye-aws, getsaurabh02, sbcd90, praveensameneni, amsiglan and AWSHurneyt as code owners

August 14, 2024 23:48

riysaxen-amzn and others added 10 commits

August 14, 2024 16:49


          added release notes 2.16 (opensearch-project#227)

37b6cbb

* added release notes 2.16

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* added release notes for 2.16

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          chanels complete

17976f7

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          almost done

e55c9c5

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          corrected Chanel list page

9ad26d8

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          view channel

0c1f20e

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          view channel

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          channel details fixed

82f1cda

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          fixed many things

229f18e

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          bug fixes

9ebcf49

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          fix tests page header changes

d48f441

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

riysaxen-amzn force-pushed the page-header branch from 80e7f98 to d48f441 Compare

August 14, 2024 23:49

riysaxen-amzn and others added 3 commits

August 14, 2024 16:50


          Merge branch 'main' into page-header

051340c


          code refactored

e7e6be4

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          fix UTs

5bbf306

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

AWSHurneyt approved these changes

View reviewed changes

Collaborator

AWSHurneyt left a comment •

edited

Loading

It would be a good idea to have someone with a bit more context into the changes review the PR as well though, even if they're not a maintainer. From my perspective though, I'm approving as it LGTM.

riysaxen-amzn added 4 commits

August 19, 2024 09:41


          Compressed UX

ff8dd09

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          resolve merge conflict from main

0fb784a

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          resolve merge conflict from main

d42dbfd

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          resolve merge conflict from main

10bbaad

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

amsiglan reviewed

View reviewed changes

.babelrc Outdated Show resolved Hide resolved

amsiglan reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

amsiglan reviewed

View reviewed changes

package.json Show resolved Hide resolved


          refactored the code

dc8273b

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

amsiglan reviewed

View reviewed changes

public/pages/Channels/Channels.tsx Outdated Show resolved Hide resolved

riysaxen-amzn added 2 commits

August 19, 2024 15:18


          refactored the code

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          addressed the comment

7f16773

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

amsiglan reviewed

View reviewed changes

public/pages/Channels/components/details/ChannelDetails.tsx Outdated Show resolved Hide resolved

amsiglan reviewed

View reviewed changes

public/pages/Channels/components/details/ChannelDetails.tsx Outdated Show resolved Hide resolved

amsiglan reviewed

View reviewed changes

public/pages/Emails/components/tables/RecipientGroupsTable.tsx Outdated Show resolved Hide resolved

amsiglan reviewed

View reviewed changes

test/polyfills/mutationObserver.js Outdated Show resolved Hide resolved

riysaxen-amzn added 2 commits

August 19, 2024 22:30


          addressed the comment

03f13df

Signed-off-by: Riya Saxena <riysaxen@amazon.com>


          addressed the comment

37c3d37

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

amsiglan reviewed

View reviewed changes

test/setup.jest.ts Outdated Show resolved Hide resolved


          addressed the comment

1bb86a8

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

amsiglan reviewed

View reviewed changes

public/pages/Emails/components/tables/RecipientGroupsTable.tsx Outdated

Comment on lines 308 to 313

+                                    <PageHeader
+                                      appRightControls={headerControls}
+                                      appLeftControls={[
+                                        { renderComponent: totalEmailGroups },
+                                      ]}
+                                    />

Collaborator

amsiglan Aug 20, 2024

This shouldn't go inside the action, instead be outside the ContentPanel

amsiglan approved these changes

View reviewed changes

amsiglan added the backport 2.x label

AWSHurneyt merged commit 33d7bc1 into opensearch-project:main

9 checks passed

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Page header (#236)

* added release notes 2.16 (#227)

* added release notes 2.16

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* added release notes for 2.16

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* chanels complete

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* almost done

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* corrected Chanel list page

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* view channel

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* view channel

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* channel details fixed

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fixed many things

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* bug fixes

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fix tests page header changes

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* code refactored

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fix UTs

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* Compressed UX

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* resolve merge conflict from main

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* resolve merge conflict from main

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* refactored the code

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* refactored the code

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* addressed the comment

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* addressed the comment

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* addressed the comment

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* addressed the comment

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
(cherry picked from commit 33d7bc1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.x] Page header #239

Merged

AWSHurneyt pushed a commit that referenced this pull request


          Page header (#236) (#239)

dec3f88

* added release notes 2.16 (#227)

* added release notes 2.16



* added release notes for 2.16



---------



* chanels complete



* almost done



* corrected Chanel list page



* view channel



* view channel



* channel details fixed



* fixed many things



* bug fixes



* fix tests page header changes



* code refactored



* fix UTs



* Compressed UX



* resolve merge conflict from main



* resolve merge conflict from main



* refactored the code



* refactored the code



* addressed the comment



* addressed the comment



* addressed the comment



* addressed the comment



---------


(cherry picked from commit 33d7bc1)

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

amsiglan amsiglan approved these changes

AWSHurneyt AWSHurneyt approved these changes

xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

gaobinlong Awaiting requested review from gaobinlong gaobinlong is a code owner

Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws is a code owner

yuye-aws Awaiting requested review from yuye-aws yuye-aws is a code owner

getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

Labels