Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.13] Correctly Utilize Cache in Tables Flyout #1664

Draft
wants to merge 1 commit into
base: 2.13
Choose a base branch
from
Draft

[Backport 2.13] Correctly Utilize Cache in Tables Flyout #1664

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3be2d39 from #1662.

@github-actions
Correctly Utilize Cache in Tables Flyout (#1662)
31f17fe 
* correctly check for cache on table flyout

Signed-off-by: Sean Li <lnse@amazon.com>

* skip start loading if fail

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit 3be2d39)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 57.89%. Comparing base (606bc71) to head (31f17fe).

Files Patch % Lines
...ated_objects/associated_objects_details_flyout.tsx 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.13    #1664      +/-   ##
==========================================
- Coverage   57.92%   57.89%   -0.03%     
==========================================
  Files         365      365              
  Lines       13727    13734       +7     
  Branches     3615     3617       +2     
==========================================
  Hits         7951     7951              
- Misses       5713     5720       +7     
  Partials       63       63
Flag Coverage Δ
dashboards-observability 57.89% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 marked this pull request as draft March 29, 2024 21:41
@RyanL1997 RyanL1997 added the enhancement New feature or request label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanL1997 RyanL1997 RyanL1997 approved these changes

@Swiddis Swiddis Swiddis approved these changes

@ps48 ps48 ps48 approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@TackAdam TackAdam Awaiting requested review from TackAdam TackAdam will be requested when the pull request is marked ready for review TackAdam is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ps48 @Swiddis @RyanL1997