Add uiSetting to adopt interface changes #2013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric <menwe@amazon.com>
mengweieric
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
approved these changes
Jul 30, 2024
paulstn
reviewed
Jul 30, 2024
| @@ -34,6 +36,8 @@ class CoreRefs { | |||
| public dashboardProviders?: unknown; | |||
| public overlays?: OverlayStart; | |||
| public dataSource?: DataSourcePluginStart; | |||
| public dataSources?: DataSourceStart; | |||
There was a problem hiding this comment.
Both of these coreRefs have very similar names, is there plans to change the naming?
sumukhswamy
approved these changes
Jul 30, 2024
|
Please don't merge this PR for now as this PR needs the corresponding changes in core dashboards: opensearch-project/OpenSearch-Dashboards#7584 these 2 PRs need to go in together. Will update with next step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add uiSetting to adopt interface changes from upstream data source selectable.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.