[BUG] Traces and Spans tab Fix for application analytics #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha and
paulstn
as code owners
|
SQL plugin installation seems to have a failure on main |
joshuali925
approved these changes
Aug 1, 2024
ps48
approved these changes
Aug 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
==========================================
- Coverage 57.85% 54.73% -3.13%
==========================================
Files 372 394 +22
Lines 14081 15231 +1150
Branches 3712 4026 +314
==========================================
+ Hits 8146 8336 +190
- Misses 5871 6815 +944
- Partials 64 80 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YANG-DB
approved these changes
Aug 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit e7dd671) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit e7dd671) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit e7dd671) Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit e7dd671) Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
pushed a commit
to TackAdam/dashboards-observability
that referenced
this pull request
Aug 20, 2024
…t#2023) Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the Traces and Span tab in application analytics was crashing as the MDS-ID was not being sent in to the traces page
Issues Resolved
#1931
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.