Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohesion main to 2.7 #382

Merged
merged 24 commits into from
Apr 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1e63445
baseline repo permissions and groups (#314)
derek-ho Mar 31, 2023
79c807a
bug fix for empty connected services array (#339)
derek-ho Apr 3, 2023
03bdf6d
Refactor Saved objects and add visualization embeddable (#341)
mengweieric Apr 13, 2023
bc792b7
[Feature] Saved object refactoring for panels (#355)
mengweieric Apr 14, 2023
df82345
Fix saved visualization edit url in visualize (#359)
joshuali925 Apr 17, 2023
1c7f8e3
[Panel] Fix panel resizing and date picker bugs (#364)
mengweieric Apr 17, 2023
a3056b7
Reorganize 3_panels.spec.ts E2E (#362)
Apr 17, 2023
9cef044
fix traces side nav (#360)
ps48 Apr 17, 2023
1818418
[Fix] Panels/Dashboard Duplicate Action fails when source is saved-ob…
Apr 17, 2023
5dd0c74
bulk update separation (#356)
derek-ho Apr 17, 2023
3e976d5
Fix side nav minor bugs (#365)
ps48 Apr 17, 2023
d07f029
fix replace in new so panel (#367)
derek-ho Apr 17, 2023
a0187fd
Minor left nav fixes (#368)
rupal-bq Apr 17, 2023
6fd1d6c
Recover Panel View Legacy - Duplicate Action (#366)
pjfitzgibbons Apr 17, 2023
a6298d2
fix deleted import (#370)
derek-ho Apr 17, 2023
c587da9
Fix crash at loading app analytics tabs (#369)
joshuali925 Apr 17, 2023
4ccd465
fix history issue (#371)
mengweieric Apr 17, 2023
102ead3
fix re-direct links for visualizaitons in notebooks, metrics (#372)
ps48 Apr 17, 2023
8e11fb7
Support new notebooks URL for reporting (#373)
joshuali925 Apr 17, 2023
dfadf35
fix legacy route for traces (#374)
ps48 Apr 17, 2023
873321d
Recover Panel View Legacy - Duplicate Action (#376)
pjfitzgibbons Apr 17, 2023
237332a
Organize imports on custom panels home file (#377)
joshuali925 Apr 17, 2023
4b256c1
fix doc viewer flyout styling in explorer (#378)
ps48 Apr 18, 2023
945fca4
Rename Panels => Observability Dashboard (#380)
Apr 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions .cypress/plugins/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,14 @@
// This function is called when a project is opened or re-opened (e.g. due to
// the project's config changing)


/**
* @type {Cypress.PluginConfig}
*/
module.exports = (on, config) => {
// `on` is used to hook into various events Cypress emits
// `config` is the resolved Cypress config
require('cypress-watch-and-reload/plugins')(config)

return config
}
2 changes: 2 additions & 0 deletions .cypress/support/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
// https://on.cypress.io/configuration
// ***********************************************************

import 'cypress-watch-and-reload/support'

// Import commands.js using ES2015 syntax:
import './commands';

Expand Down
2 changes: 0 additions & 2 deletions .github/CODEOWNERS

This file was deleted.

2 changes: 2 additions & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# This should match the owning team set up in https://github.com/orgs/opensearch-project/teams
* @pjfitzgibbons @anirudha @ps48 @kavithacm @derek-ho @joshuali925 @dai-chen @YANG-DB @rupal-bq @mengweieric @vamsi-amazon @swiddis
11 changes: 10 additions & 1 deletion MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,13 @@
| Rupal Mahajan | [rupal-bq](https://github.com/rupal-bq) | Amazon |
| Derek Ho | [derek-ho](https://github.com/derek-ho) | Amazon |
| Lior Perry | [YANG-DB](https://github.com/YANG-DB) | Amazon |
| Peter Fitzgibbons | [pjfitzgibbons](https://github.com/pjfitzgibbons) | Amazon |
| Peter Fitzgibbons | [pjfitzgibbons](https://github.com/pjfitzgibbons) | Amazon |
| Simeon Widdis | [swiddis] (https://github.com/swiddis) | Amazon |

## Emeritus Maintainers

| Maintainer | GitHub ID | Affiliation |
| ----------------- | ------------------------------------------------------- | ----------- |
| Charlotte Henkle | [CEHENKLE](https://github.com/CEHENKLE) | Amazon |
| Anirudha Jadhav | [anirudha](https://github.com/anirudha) | Amazon |
| Nick Knize | [nknize](https://github.com/nknize) | Amazon |
7 changes: 6 additions & 1 deletion common/constants/custom_panels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,10 @@
*/

export const CUSTOM_PANELS_API_PREFIX = '/api/observability/operational_panels';
export const CUSTOM_PANELS_DOCUMENTATION_URL = 'https://opensearch.org/docs/latest/observability-plugin/operational-panels/';
export const CUSTOM_PANELS_DOCUMENTATION_URL =
'https://opensearch.org/docs/latest/observability-plugin/operational-panels/';
export const CREATE_PANEL_MESSAGE = 'Enter a name to describe the purpose of this custom panel.';

export const CUSTOM_PANELS_SAVED_OBJECT_TYPE = 'observability-panel';

export const CUSTOM_PANEL_SLICE = 'customPanel';
2 changes: 1 addition & 1 deletion common/constants/shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const PPL_ENDPOINT = '/_plugins/_ppl';
export const SQL_ENDPOINT = '/_plugins/_sql';
export const DSL_ENDPOINT = '/_plugins/_dsl';

export const observabilityID = 'observability-dashboards';
export const observabilityID = 'observability-logs';
export const observabilityTitle = 'Observability';
export const observabilityPluginOrder = 6000;

Expand Down
37 changes: 34 additions & 3 deletions common/types/custom_panels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,19 @@
*/

export interface CustomPanelListType {
name: string;
title: string;
id: string;
dateCreated: number;
dateModified: number;
applicationId?: string;
savedObject: boolean;
}

export interface BoxType {
x1: number;
y1: number;
x2: number;
y2: number;
}

export interface VisualizationType {
Expand All @@ -21,13 +29,19 @@ export interface VisualizationType {
}

export interface PanelType {
name: string;
title: string;
dateCreated: number;
dateModified: number;
visualizations: VisualizationType[];
timeRange: { to: string; from: string };
queryFilter: { query: string; language: string };
applicationId?: string;
}

export interface CustomPanelType extends PanelType {
id: string;
}

export interface SavedVisualizationType {
id: string;
name: string;
Expand All @@ -39,7 +53,7 @@ export interface SavedVisualizationType {
user_configs: any;
}

export interface pplResponse {
export interface PPLResponse {
data: any;
metadata: any;
size: number;
Expand All @@ -50,3 +64,20 @@ export interface VizContainerError {
errorMessage: string;
errorDetails?: string;
}

export interface ObservabilityPanelAttrs {
title: string;
description: string;
dateCreated: number;
dateModified: number;
timeRange: {
to: string;
from: string;
};
queryFilter: {
query: string;
language: string;
};
visualizations: VisualizationType[];
applicationId: string;
}
4 changes: 3 additions & 1 deletion common/types/explorer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
SavedObjectAttributes,
SavedObjectsStart,
} from '../../../../src/core/public/saved_objects';
import { ChromeBreadcrumb } from '../../../../src/core/public/chrome';

export interface IQueryTab {
id: string;
Expand Down Expand Up @@ -318,14 +319,15 @@ export interface Breadcrumbs {

export interface EventAnalyticsProps {
chrome: CoreSetup;
parentBreadcrumbs: Breadcrumbs[];
parentBreadcrumbs: ChromeBreadcrumb[];
pplService: any;
dslService: any;
savedObjects: SavedObjectsStart;
timestampUtils: TimestampUtils;
http: HttpStart;
notifications: NotificationsStart;
queryManager: QueryManager;
setBreadcrumbs: (newBreadcrumbs: ChromeBreadcrumb[]) => void;
}

export interface DataConfigPanelProps {
Expand Down
5 changes: 4 additions & 1 deletion cypress.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"baseUrl": "http://localhost:5601",
"video": true,
"chromeWebSecurity": false,
"chromeWebSecurity": true,
"fixturesFolder": ".cypress/fixtures",
"integrationFolder": ".cypress/integration",
"pluginsFile": ".cypress/plugins/index.js",
Expand All @@ -19,5 +19,8 @@
"opensearch": "localhost:9200",
"opensearchDashboards": "localhost:5601",
"security_enabled": true
},
"cypress-watch-and-reload": {
"watch": ["common/**", "public/**", "server/**"]
}
}
20 changes: 16 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,20 @@
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../scripts/osd",
"build": "yarn plugin_helpers build",
"build": "yarn plugin-helpers build",
"test": "../../node_modules/.bin/jest --config ./test/jest.config.js",
"cypress:run": "TZ=America/Los_Angeles cypress run",
"cypress:open": "TZ=America/Los_Angeles cypress open",
"plugin_helpers": "node ../../scripts/plugin_helpers"
"plugin-helpers": "node ../../scripts/plugin_helpers",
"prepare": "husky install",
"lint:es": "node ../../scripts/eslint",
"lint": "yarn lint:es"
},
"lint-staged": {
"*.{ts,tsx,js,jsx}": [
"yarn lint --fix",
"git add"
]
},
"dependencies": {
"@algolia/autocomplete-core": "^1.4.1",
Expand All @@ -21,13 +30,13 @@
"ag-grid-react": "^27.3.0",
"antlr4": "4.8.0",
"antlr4ts": "^0.5.0-alpha.4",
"performance-now": "^2.1.0",
"plotly.js-dist": "^2.2.0",
"postinstall": "^0.7.4",
"react-graph-vis": "^1.0.5",
"react-paginate": "^8.1.3",
"react-plotly.js": "^2.5.1",
"redux-persist": "^6.0.0"
"redux-persist": "^6.0.0",
"performance-now": "^2.1.0"
},
"devDependencies": {
"@cypress/skip-test": "^2.6.1",
Expand All @@ -36,8 +45,11 @@
"@types/react-test-renderer": "^16.9.1",
"antlr4ts-cli": "^0.5.0-alpha.4",
"cypress": "^6.0.0",
"cypress-watch-and-reload": "^1.10.6",
"eslint": "^6.8.0",
"husky": "6.0.0",
"jest-dom": "^4.0.0",
"lint-staged": "^13.1.0",
"ts-jest": "^29.1.0"
},
"resolutions": {
Expand Down
Loading