Remove styling causing issue for banner in advanced settings #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Wei <menwe@amazon.com>
mengweieric
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 42.81% 42.81%
=======================================
Files 299 299
Lines 17784 17784
Branches 4355 4355
=======================================
Hits 7615 7615
Misses 10128 10128
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. |
ps48
approved these changes
May 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 952ed38)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 952ed38)
ps48
pushed a commit
that referenced
this pull request
May 30, 2023
ps48
pushed a commit
that referenced
this pull request
May 30, 2023
pjfitzgibbons
pushed a commit
to TackAdam/dashboards-observability
that referenced
this pull request
Jun 5, 2023
…roject#488) Signed-off-by: Eric Wei <menwe@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…roject#488) (opensearch-project#501) Signed-off-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 952ed38) Co-authored-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 0ac794d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
in advanced setting page of Core Dashboard, if you made a change, a banner should show up on the bottom of the page
but currently in main, it is missing.
Root cause:
Changes in main of dashboard core moved that banner code from a sibling div to under the main body with an id of '#opensearch-dashboards-body'. Observability also refer to this id for its own styling previously affecting that banner.
Versions like 2.7 which do not see such bug have DOM structure like
where banner section with 'label Page level controls' locates out side of 'opensearch-dashboards-body' whereas in main:
It got moved to under body div.
Fix
Removed styling which didn't have actual effect currently for observability but affecting that banner. Also moving forward, observability will add wrapper / its own class name to avoid possible global styling.
Issues Resolved
#484
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.