Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stylelint issues #634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BSFishy
Copy link

@BSFishy BSFishy commented Jul 11, 2023

Description

Fix issues that Stylelint throws. This is the second step to onboard Stylelint.

Issues Resolved

Paritally resolve #630

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>
@BSFishy
Copy link
Author

BSFishy commented Jul 11, 2023

There are still a few issues:

public/components/metrics/index.scss
 17:1  ✖  Modifying global selector ".mainContentTabs .euiResizableContainer" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

public/components/notebooks/index.scss
  7:3  ✖  Usage of property "font-family" is not allowed. (no_restricted_properties)  @osd/stylelint/no_restricted_properties
 24:3  ✖  Usage of property "font-family" is not allowed. (no_restricted_properties)  @osd/stylelint/no_restricted_properties

public/components/event_analytics/explorer/explorer.scss
 17:1  ✖  Modifying global selector ".mainContentTabs .euiResizableContainer" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

public/components/event_analytics/explorer/log_explorer.scss
 7:3  ✖  Modifying global selector ".euiTabs" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

public/components/metrics/sidebar/sidebar.scss
 67:3  ✖  Modifying global selector ".euiButton__content" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

public/components/event_analytics/explorer/events_views/data_grid.scss
 291:7  ✖  Usage of property "font-family" is not allowed. (no_restricted_properties)  @osd/stylelint/no_restricted_properties
 453:7  ✖  Usage of property "font-family" is not allowed. (no_restricted_properties)  @osd/stylelint/no_restricted_properties

public/components/event_analytics/explorer/events_views/docView.scss
 16:1  ✖  Modifying global selector ".doc-flyout td.eui-textNoWrap" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

public/components/event_analytics/explorer/sidebar/sidebar.scss
 55:3  ✖  Modifying global selector ".euiButton__content" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

public/components/visualizations/charts/data_table/data_table.scss
 19:1  ✖  Modifying global selector ".custom-pagination-container .euiIcon:focus" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

public/components/event_analytics/explorer/visualizations/config_panel/config_panel.scss
 116:1  ✖  Modifying global selector ".euiComboBoxOptionsList__rowWrap" not allowed. (no_modifying_global_selectors)                                      @osd/stylelint/no_modifying_global_selectors
 120:1  ✖  Modifying global selector ".euiComboBoxOptionsList__rowWrap > div" not allowed. (no_modifying_global_selectors)                                @osd/stylelint/no_modifying_global_selectors
 136:5  ✖  Modifying global selector ".euiBadge" not allowed. (no_modifying_global_selectors)                                                             @osd/stylelint/no_modifying_global_selectors
 184:1  ✖  Modifying global selector ".color-theme-combo-box-option .euiFlexItem.euiFlexItem--flexGrowZero" not allowed. (no_modifying_global_selectors)  @osd/stylelint/no_modifying_global_selectors

How should these be handled? Can they be fixed in followup PR's?

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #634 (e6a4362) into main (e1a5465) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   43.63%   43.63%           
=======================================
  Files         313      313           
  Lines       18596    18596           
  Branches     4485     4485           
=======================================
  Hits         8115     8115           
  Misses      10439    10439           
  Partials       42       42           
Flag Coverage Δ
dashboards-observability 43.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard Stylelint
1 participant