Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize cache behavior on CI #925

Closed
wants to merge 8 commits into from

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Aug 14, 2023

Description

Per post-merge feedback on #901, this PR applies some more minor tweaks to the CI, including configuring a better cache and using the retry action instead of manual attempts.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis Swiddis changed the title Use retry action for OSD bootstrap and simplify cache Optimize cache behavior on CI Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #925 (0569932) into main (29f6028) will not change coverage.
The diff coverage is n/a.

❗ Current head 0569932 differs from pull request most recent head 7a4110b. Consider uploading reports for the commit 7a4110b to get more accurate results

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   43.72%   43.72%           
=======================================
  Files         313      313           
  Lines       18629    18629           
  Branches     4534     4534           
=======================================
  Hits         8146     8146           
  Misses       9932     9932           
  Partials      551      551           
Flag Coverage Δ
dashboards-observability 43.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Aug 14, 2023

Closing as the cache change seems to have almost no effect on bootstrap times, even on a cache hit. This is despite needing 150 additional MB of storage with the new cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant