added new changes for the sidebar #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
ps48
reviewed
Sep 18, 2023
public/components/Main/main.tsx
Outdated
Comment on lines
686
to
691
| // const [isClearable, setIsClearable] = useState(true); | ||
|
|
||
| // const [value, setValue] = useState(''); | ||
| // const onChange = (e) => { | ||
| // setValue(e.target.value); | ||
| // }; |
There was a problem hiding this comment.
Can you please remove the commented code
ps48
reviewed
Sep 18, 2023
public/components/Main/main.tsx
Outdated
| import { IHttpResponse } from 'angular'; | ||
| import _ from 'lodash'; | ||
| import React from 'react'; | ||
| import React, { useState } from 'react'; |
There was a problem hiding this comment.
useState , EuiPageTemplate are unused headers can you please remove them?
ps48
reviewed
Sep 18, 2023
Codecov Report
@@ Coverage Diff @@
## feature/flint-ui #124 +/- ##
====================================================
+ Coverage 62.76% 62.82% +0.05%
====================================================
Files 10 10
Lines 658 659 +1
Branches 119 119
====================================================
+ Hits 413 414 +1
Misses 192 192
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
derek-ho
reviewed
Sep 21, 2023
| @@ -3,7 +3,7 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| import { EuiButton, EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle } from '@elastic/eui'; | |||
| import { EuiButton, EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle, EuiPageSideBar ,EuiSideNav, EuiPanel, EuiPageTemplate, EuiPage, EuiPageContent, EuiPageContentBody, EuiFlexGrid, EuiSplitPanel, EuiComboBox, EuiText, EuiPagination, EuiPopover, EuiFieldSearch} from '@elastic/eui'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added data connections tab in the sidebar
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.