Update form validations and tests for acceleration #133

ps48 · 2023-10-02T15:50:40Z

Description

Update form validations for form components in acceleration
Add Immer where setState bloats up
Add Jest tests to all acceleration components

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

codecov · 2023-10-02T15:56:28Z

Codecov Report

Merging #133 (f146eb6) into main (9fd9314) will increase coverage by 13.50%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #133       +/-   ##
===========================================
+ Coverage   45.23%   58.73%   +13.50%     
===========================================
  Files          29       29               
  Lines        1017     1122      +105     
  Branches      155      177       +22     
===========================================
+ Hits          460      659      +199     
+ Misses        502      394      -108     
- Partials       55       69       +14

Flag	Coverage Δ
dashboards-query-workbench	`58.73% <ø> (+13.50%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

joshuali925 · 2023-10-02T22:43:54Z

public/components/acceleration/create/create_acceleration.tsx

  });

  const copyToEditor = () => {
+    const errors = formValidator(accelerationFormData);
+    if (Object.values(errors).some((e) => !!e.length)) {


Suggested change

if (Object.values(errors).some((e) => !!e.length)) {

if (hasError(errors)) {

Updated: 8d2e9e1

joshuali925 · 2023-10-02T22:45:51Z

public/components/acceleration/selectors/index_setting_options.tsx

+          onBlur={(e) => {
+            setAccelerationFormData(
+              producer((accData) => {
+                accData.formErrors.primaryShardsError = validatePrimaryShardCount(+e.target.value);


nit. could you use parseInt to convert e.target.value? i prefer it because it's more explicit, and conventionally there are some style guides preferring casting over coercion https://github.com/airbnb/javascript#coercion--numbers

Makes sense, Updated: 8d2e9e1

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

…t#133) * update form validaitons Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots, add skipping validator Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update sqlpage snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add tests for acceleration create Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acceleration builder tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding fix for windows snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot files Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Add table acceleration flyout (#128) * Add table acceleration flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * comment on hardcoded elements Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * additional comment on hardcoded Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove console logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * review fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert version changes, inline type declare Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Increment version to 3.0.0.0 (#121) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Add materialized view visual builder and query builders (#129) * add materialized view visual builder and query builders Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * organize header and PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Define tables (#126) * added changes for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added side bar with tables indexed Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added dynamic element for tree view, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * made a few design and panel changes, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changed the constants file Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for search bar removal, pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * readded console.log Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated test suites, removed search field Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for Data connection and combo box Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock for http query Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock template name in tests Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed more comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added error message for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * update packages and tsconfig (#130) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update form validations and tests for acceleration (#133) * update form validaitons Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots, add skipping validator Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update sqlpage snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add tests for acceleration create Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acceleration builder tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding fix for windows snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot files Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * implementing async query support with polling (#131) * successfully getting async post requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * get query with hardcoded job id working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * working spark query after constant time wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added polling with some hardcoded values Signed-off-by: Paul Sebastian <paulstn@amazon.com> * ability to switch between sources implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented basic spinner Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small pr asks and cancellation implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixing small clear state issues Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reduce route name redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove multiple query implementation for async Signed-off-by: Paul Sebastian <paulstn@amazon.com> * needed to modify the endpoint Signed-off-by: Paul Sebastian <paulstn@amazon.com> * default data source being Opensearch and updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added the skipping index queries, covering index queries,updates the … (#134) * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * reverted updates to yarn Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests, snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Acceleration related changes and minor fixes (#135) * add acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove [if not exists] from acc creation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * merge tableview from main Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add hash router Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * hide materialized view index type Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * loading combo boxes for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acceleration backend integ Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update jest tests for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add redirection support for home page Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix primary shards count and replica validation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove the caution callout for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * support acc flyout redirection from data sources Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * disable buttons while running async query (#136) * disable most buttons Signed-off-by: Paul Sebastian <paulstn@amazon.com> * code editor read only Signed-off-by: Paul Sebastian <paulstn@amazon.com> * disabled accelerate button Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Design changes for the sidebar and update to create button (#138) * added changes for loading, create button Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * removed comments, updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots, constant for skipping index Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Load table fields for acceleration index flyout (#137) * load table fields after table is selected Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * simplify the map function Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

* Updated MAINTAINERS.md to match recommended opensearch-project format. (opensearch-project#18) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> * Add .whitesource configuration file (#1) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Bump json5 from 2.2.1 to 2.2.3 (opensearch-project#20) Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding release notes (opensearch-project#28) (opensearch-project#30) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 5dde647) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Rename plugin_helpers to plugin-helpers (opensearch-project#31) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add resolution for ansi-regex (opensearch-project#38) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Upgrade hapi-latest to fix CVE-2023-25166 (opensearch-project#39) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Created untriaged issue workflow. (opensearch-project#42) Signed-off-by: dblock <dblock@amazon.com> * Fix Node.js and Yarn installation in CI (opensearch-project#44) Signed-off-by: Miki <miki@amazon.com> * add release notes for 2.6 query workbench (opensearch-project#48) (opensearch-project#50) * add release notes for 2.6 query workbench Signed-off-by: Derek Ho <dxho@amazon.com> * add CI item in infra Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 5cecd8d) Co-authored-by: Derek Ho <dxho@amazon.com> * baseline repo groups (opensearch-project#52) Signed-off-by: Derek Ho <dxho@amazon.com> * Add 2.7 release note (opensearch-project#57) Signed-off-by: Chen Dai <daichen@amazon.com> * Add fix for CVE-2023-2251 (opensearch-project#60) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * update maintainers and code owners (opensearch-project#64) * update maintainers and code owners Signed-off-by: Derek Ho <dxho@amazon.com> * add ani to codeowners Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add release notes for 2.8 (opensearch-project#75) * Add release notes for 2.8 Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update release notes Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use valid json for mock data in unit tests (opensearch-project#76) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update default query. (opensearch-project#81) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update CI. (opensearch-project#82) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Increment version to 3.0.0.0 (opensearch-project#66) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Upgrade tough-cookie and semver (opensearch-project#90) * Upgrade tough-cookie to fix CVE-2023-26136 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add semver resolution to patch CVE-2022-25883 Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add release notes for 2.9.0 (opensearch-project#93) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Bump word-wrap from 1.2.3 to 1.2.4 (opensearch-project#99) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update fail backport (opensearch-project#104) Signed-off-by: Derek Ho <dxho@amazon.com> * Update backport CI, add PR merged condition (opensearch-project#111) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update searchbar snapshots according to upstream changes (opensearch-project#115) Signed-off-by: Derek Ho <dxho@amazon.com> * add release notes for 2.10.0 (opensearch-project#117) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Upgrade cypress/request (opensearch-project#120) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add table acceleration flyout (opensearch-project#128) * Add table acceleration flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * comment on hardcoded elements Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * additional comment on hardcoded Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove console logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * review fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert version changes, inline type declare Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Increment version to 3.0.0.0 (opensearch-project#121) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Add materialized view visual builder and query builders (opensearch-project#129) * add materialized view visual builder and query builders Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * organize header and PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Define tables (opensearch-project#126) * added changes for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added side bar with tables indexed Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added dynamic element for tree view, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * made a few design and panel changes, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changed the constants file Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for search bar removal, pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * readded console.log Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated test suites, removed search field Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for Data connection and combo box Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock for http query Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock template name in tests Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed more comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added error message for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * update packages and tsconfig (opensearch-project#130) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update form validations and tests for acceleration (opensearch-project#133) * update form validaitons Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots, add skipping validator Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update sqlpage snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add tests for acceleration create Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acceleration builder tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding fix for windows snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot files Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * implementing async query support with polling (opensearch-project#131) * successfully getting async post requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * get query with hardcoded job id working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * working spark query after constant time wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added polling with some hardcoded values Signed-off-by: Paul Sebastian <paulstn@amazon.com> * ability to switch between sources implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented basic spinner Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small pr asks and cancellation implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixing small clear state issues Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reduce route name redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove multiple query implementation for async Signed-off-by: Paul Sebastian <paulstn@amazon.com> * needed to modify the endpoint Signed-off-by: Paul Sebastian <paulstn@amazon.com> * default data source being Opensearch and updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added the skipping index queries, covering index queries,updates the … (opensearch-project#134) * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * reverted updates to yarn Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests, snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Acceleration related changes and minor fixes (opensearch-project#135) * add acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove [if not exists] from acc creation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * merge tableview from main Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add hash router Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * hide materialized view index type Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * loading combo boxes for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acceleration backend integ Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update jest tests for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add redirection support for home page Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix primary shards count and replica validation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove the caution callout for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * support acc flyout redirection from data sources Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * disable buttons while running async query (opensearch-project#136) * disable most buttons Signed-off-by: Paul Sebastian <paulstn@amazon.com> * code editor read only Signed-off-by: Paul Sebastian <paulstn@amazon.com> * disabled accelerate button Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Design changes for the sidebar and update to create button (opensearch-project#138) * added changes for loading, create button Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * removed comments, updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots, constant for skipping index Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Load table fields for acceleration index flyout (opensearch-project#137) * load table fields after table is selected Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * simplify the map function Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Adding minor updates and bug fixes (opensearch-project#140) * adding minor updates to acceleration ui Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * edits to acceleration index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding minor edits to table view Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove console log Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * minor fixes to namings and tableview Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tableview clear db Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Chen Dai <daichen@amazon.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

update form validaitons

8733e80

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

ps48 requested review from pjfitzgibbons, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vmmusings, Swiddis, penghuo, seankao-az, MaxKsyunz, Yury-Fridlyand and anirudha as code owners October 2, 2023 15:50

ps48 marked this pull request as draft October 2, 2023 15:50

ps48 changed the title ~~Update form validaitons and tests for acceleration~~ [WIP] Update form validaitons and tests for acceleration Oct 2, 2023

ps48 added 2 commits October 2, 2023 09:12

update snapshots, add skipping validator

25449ef

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

update sqlpage snapshot

835e6b4

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

YANG-DB approved these changes Oct 2, 2023

View reviewed changes

YANG-DB self-requested a review October 2, 2023 19:57

add tests for acceleration create

2fbb601

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

ps48 changed the title ~~[WIP] Update form validaitons and tests for acceleration~~ [WIP] Update form validations and tests for acceleration Oct 2, 2023

joshuali925 approved these changes Oct 2, 2023

View reviewed changes

ps48 added 2 commits October 2, 2023 23:41

update acceleration builder tests

882c27e

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

update PR comments

8d2e9e1

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

ps48 changed the title ~~[WIP] Update form validations and tests for acceleration~~ Update form validations and tests for acceleration Oct 3, 2023

ps48 marked this pull request as ready for review October 3, 2023 06:54

ps48 added 2 commits October 3, 2023 07:40

adding fix for windows snapshots

e06efcb

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

update snapshot files

f146eb6

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

ps48 merged commit b506714 into opensearch-project:main Oct 3, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update form validations and tests for acceleration #133

Update form validations and tests for acceleration #133

ps48 commented Oct 2, 2023 •

edited

Loading

codecov bot commented Oct 2, 2023 •

edited

Loading

joshuali925 Oct 2, 2023

ps48 Oct 3, 2023

joshuali925 Oct 2, 2023

ps48 Oct 3, 2023

	if (Object.values(errors).some((e) => !!e.length)) {
	if (hasError(errors)) {

Update form validations and tests for acceleration #133

Update form validations and tests for acceleration #133

Conversation

ps48 commented Oct 2, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov bot commented Oct 2, 2023 • edited Loading

Codecov Report

joshuali925 Oct 2, 2023

Choose a reason for hiding this comment

ps48 Oct 3, 2023

Choose a reason for hiding this comment

joshuali925 Oct 2, 2023

Choose a reason for hiding this comment

ps48 Oct 3, 2023

Choose a reason for hiding this comment

ps48 commented Oct 2, 2023 •

edited

Loading

codecov bot commented Oct 2, 2023 •

edited

Loading