Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node.js and Yarn installation in CI #64

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix Node.js and Yarn installation in CI #64

merged 1 commit into from
Feb 22, 2023

Conversation

AMoo-Miki
Copy link
Contributor

Description

The GitHub workflow uses the engines from OSD incorrectly. This change fixes that.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki AMoo-Miki requested a review from a team as a code owner February 22, 2023 05:44
@AMoo-Miki
Fix Node.js and Yarn installation in CI
76878ac 
Signed-off-by: Miki <miki@amazon.com>
rupal-bq
rupal-bq approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@rupal-bq rupal-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupal-bq rupal-bq merged commit 6c9b69b into opensearch-project:main Feb 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
@AMoo-Miki @github-actions
Fix Node.js and Yarn installation in CI (#64)
62f47d6 
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 6c9b69b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 22, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
@AMoo-Miki @github-actions
Fix Node.js and Yarn installation in CI (#64)
5a51e39 
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 6c9b69b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 22, 2023
Merged
joshuali925 pushed a commit that referenced this pull request Feb 22, 2023
@opensearch-trigger-bot @AMoo-Miki
Fix Node.js and Yarn installation in CI (#64) (#67)
5c5a207 
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 6c9b69b)

Co-authored-by: Miki <amoo_miki@yahoo.com>
rupal-bq pushed a commit that referenced this pull request Feb 22, 2023
@opensearch-trigger-bot @AMoo-Miki
Fix Node.js and Yarn installation in CI (#64) (#68)
9c849a2 
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 6c9b69b)

Co-authored-by: Miki <amoo_miki@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupal-bq rupal-bq rupal-bq approved these changes

@ps48 ps48 ps48 approved these changes

Assignees
No one assigned
Labels
backport 2.x backport 2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMoo-Miki @ps48 @rupal-bq