Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating CODEOWNERS as per issue #146 #148

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

macohen
Copy link
Collaborator

@macohen macohen commented Feb 15, 2023

Description

Addresses new standards to make maintainers clearer/more transparent

Issues Resolved

Closes #146

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mark Cohen <markcoh@amazon.com>
@macohen macohen requested a review from a team February 15, 2023 19:47
Signed-off-by: Mark Cohen <markcoh@amazon.com>
@noCharger noCharger self-requested a review February 15, 2023 21:04
@noCharger
Copy link
Collaborator

Do we need to change the merge permission as well? Right now approval from anyone of https://github.com/orgs/opensearch-project/teams/search-relevance-dashboards-team is enough for PR merge.

@macohen
Copy link
Collaborator Author

macohen commented Feb 15, 2023

Do we need to change the merge permission as well? Right now approval from anyone of https://github.com/orgs/opensearch-project/teams/search-relevance-dashboards-team is enough for PR merge.

Yes. That's the next step after this (step 6 in opensearch-project/.github#125). Before merging I need to just say hi to @dblock and ask for an assist here...

@noCharger noCharger merged commit 5c67a05 into opensearch-project:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
2 participants