Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update CONTRIBUTING.md by adding command for running tests to PR directions #335

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[Doc] Update CONTRIBUTING.md by adding command for running tests to PR directions #335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40729cb
Add command for running tests to PR directions
nung22 Oct 18, 2023
d6a869e
Add more details about -u tag
nung22 Oct 19, 2023
3527e24
Add reason for snapshot updates
nung22 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ To send us a pull request, please:

1. Fork the repository.
2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
3. Ensure local tests pass.
3. Ensure local tests pass by running `yarn test -u`. Snapshot files must always represent the current state of the code they are covering for proper testing to occur. The `-u` flag is an alias for the `--updateSnapshot` option, which automatically updates any snapshots that have been affected by your changes.
4. Commit to your fork using clear commit messages.
5. Send us a pull request, answering any default questions in the pull request interface.
6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
Expand Down
Loading