Update expiration time based on ttl on the source coordinator item. #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb2k16
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
Dec 13, 2024
|
Build is failing
Looks like not related to your commit but some other commit broke it. |
sb2k16
force-pushed
the
dynamo-add-ttl-item
branch
from
fbaa3dc to
634c031
Compare
Signed-off-by: Souvik Bose <souvbose@amazon.com>
sb2k16
force-pushed
the
dynamo-add-ttl-item
branch
from
634c031 to
2cb110d
Compare
Signed-off-by: Souvik Bose <souvbose@amazon.com>
sb2k16
force-pushed
the
dynamo-add-ttl-item
branch
from
1494745 to
839250f
Compare
dinujoh
approved these changes
Dec 16, 2024
graytaylor0
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data Prepper is not updating the expiration time on the source coordination table item when it tries to update the source partition to
ASSIGNED. This PR is to add an expiration time on the item based on the ttl.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.